Add a GraphicsPropertiesFetcher class #2071

ImperatorS79 · 2019-08-25T10:25:49Z

Fetch:

Graphics card vendor and name
OpenGL version
Vulkan version

Limitation : cannot distinguish 32 bits and 64 bits support.

Merge master

ImperatorS79 · 2019-08-25T10:30:01Z

How do I format the code correctly ?

ImperatorS79 · 2019-08-25T10:42:21Z

Hum, I have currently a bug when I launch two times a script using this. The second time it cannot load the OpenGL library :/.

ImperatorS79 · 2019-08-25T10:56:40Z

Fixed 😉.

ImperatorS79 · 2019-08-25T11:02:32Z

What should I use for the exception ?

madoar · 2019-08-25T11:02:37Z

phoenicis-tools/pom.xml

+            <activation>
+                <os>
+                    <family>unix</family>
+                    <arch>amd64</arch>


Are we limiting us in any way if we specify amd64 here?

This comes straight from LWJGL website so I do not know.

On linux and macOS LWJGL is only available in 64 bits.

What would happen if you run the code with Linux 32 bit or an older mac?

I guess it would not work, obviously. De we really want to support such old architecture ? If so, the only possible solution is to write that as an external C++ code or to simply use glxinfo/vulkaninfo as stated in #2061.

I think we should try to support as many platforms as we comfortably can. In my opinion it is likely that quite a lot of people still use older 32 bit hardware, with an older Linux 32 bit OS, but i think we should ask for some more opinions, @plata @qparis what do you think about this?

phoenicis-tools/src/main/java/org/phoenicis/tools/system/GraphicsProperties.java

phoenicis-tools/src/main/java/org/phoenicis/tools/system/GraphicsPropertiesFetcher.java

phoenicis-tools/src/main/java/org/phoenicis/tools/system/GraphicsProperties.java

madoar · 2019-08-25T11:06:35Z

What exception do you mean?

ImperatorS79 · 2019-08-25T11:11:54Z

Codacy is not happy due to RuntimeException. I also have an IllegalStateException. That code comes straight fro LWJGL start guide. I do not know what I should do here.

ImperatorS79 · 2019-08-25T11:16:28Z

I am also interested if other people could test it by adding:

.preInstall(function() {
        const graphicsProperties = Bean("graphicsPropertiesFetcher").getProperties();
        print(graphicsProperties.vendor);
        print(graphicsProperties.renderer);
        print(graphicsProperties.openGLVersion);
        print(graphicsProperties.vulkanVersion);
    });

in the 7-zip script for example. My output looks like:

Intel Open Source Technology Center
Mesa DRI Intel(R) HD Graphics 630 (Kaby Lake GT2) 
3.0
1.1.0

madoar · 2019-08-25T12:37:58Z

The IllegalStateException is fine. The RuntimeException is bad because it is quite generic. Replace it with an IllegalStateException as well and you should be fine I think.

ImperatorS79 · 2019-08-25T16:10:40Z

Seems maven cannot find LWJGL on macos, but it should 🤔.

ImperatorS79 · 2019-08-27T14:42:44Z

Now with this

.preInstall(function() {
        const graphicsProperties = Bean("graphicsPropertiesFetcher").getProperties();
        print(graphicsProperties.vendor);
        print(graphicsProperties.renderer);
        print(graphicsProperties.openglVersion);
        print(graphicsProperties.openglCoreVersion);
        print(graphicsProperties.vulkanVersion);
    });

in the 7-zip script for example, you should get something like this:

Intel Open Source Technology Center
Mesa DRI Intel(R) HD Graphics 630 (Kaby Lake GT2) 
3.0
4.5
1.1.0

@Zemogiter, @madoar, @plata feel free to test and report here 😁 👍.

Zemogiter · 2019-08-27T22:14:43Z

I'll test it in DXVK/D9VK/VK9 PRs once #2067 is merged.

ImperatorS79 · 2019-10-03T18:48:56Z

I would like to know, before continuing here, how we want to handle the graphics properties fetching.
It is really a useful tool IMO (for example to set VK_ICD_FILENAME).

madoar · 2019-10-03T18:52:39Z

We need to have a solution that either:

works for all supported operating systems/architectures
works only for a subset of the supported OSes/architectures, but doesn't crash on other OSes/architectures

Correct me if I'm wrong but I think your proposed solution does not support 32 bit architectures and even leads to a crash on it.

ImperatorS79 · 2019-10-03T18:54:53Z

It does not work on pure/only 32 bits architecture simply because LWJGL is 64 bits only on linux.
If we do not use a pure java solution the other solution is to use (on linux) glxinfo and vulkaninfo (adding mesa-utils and vulkanutils as deps)

madoar · 2019-10-03T18:57:10Z

I agree that writing a wrapper for these functions is something we should not do. Therefore my option two, i.e. simply do a check in the fetcher class where you check the architecture and OS. If the OS or architecture are unsupported by the used library return an object containing "unsupported" values

ImperatorS79 · 2019-10-03T19:00:57Z

I agree that writing a wrapper for these functions is something we should not do

What do you mean ? ^^

simply do a check in the fetcher class where you check the architecture and OS

I do not know how it works in java, but how can I compile without LWJGL on unsupported platform ?

madoar · 2019-10-03T19:09:24Z

I agree that writing a wrapper for these functions is something we should not do

What do you mean ? ^^

We have two choices if we want to provide these functions for 32 bit:

we use some other applications which return the result in text format (I think glxinfo and vulkaninfo go in this direction)
we write a small C/C++ library to fetch the necessary information, compile it for all necessary platforms and integrate it via JNI

Both solutions have their (large) issues. The first one requires that the used applications are available. The second one requires C and JNI. Both areas I would like to circumvent if we can.

simply do a check in the fetcher class where you check the architecture and OS

I do not know how it works in java, but how can I compile without LWJGL on unsupported platform ?

I expect maven to work an an unsupported platform as well. It just won't add LWJGL to the build output. This means that if you actually try to access one of its methods during runtime you will stumble over an error. Therefore we need to execute a check before any LWJGL methods are called to ensure that the library is actually available.

ImperatorS79 · 2019-10-03T19:18:12Z

And how do I do that check ?

madoar · 2019-10-03T19:22:25Z

I think https://github.com/PhoenicisOrg/phoenicis/blob/master/phoenicis-tools/src/main/java/org/phoenicis/tools/system/OperatingSystemFetcher.java and https://github.com/PhoenicisOrg/phoenicis/blob/master/phoenicis-tools/src/main/java/org/phoenicis/tools/system/ArchitectureFetcher.java will help

madoar · 2019-10-03T19:24:48Z

Another important note: I think there is no more Java 32bit version for a while now. So this may actually be the reason why LWJGL does not support 32bit?

Merge master

ImperatorS79 · 2019-10-04T07:14:42Z

@madoar I do not know why the packaging fails on macOS, the pom.xml is directly taken from lwjgl website. If you have any idea...

madoar · 2019-10-05T08:27:39Z

I have no idea as well. Maven suggests that all files exist (see https://repo1.maven.org/maven2/org/lwjgl/lwjgl-vulkan/3.2.2/ for example). Maybe the cache used by travis is out of date. I don't know if we can force an update manually. Maybe updating lwjgl to version 3.2.3 helps?

ImperatorS79 · 2019-10-05T15:58:11Z

Now it fails under macOS with

[ERROR]     'dependencies.dependency.version' for org.lwjgl:lwjgl:jar:${lwjgl.natives} is missing. @ org.phoenicis:phoenicis-tools:[unknown-version], /Users/travis/build/PhoenicisOrg/phoenicis/phoenicis-tools/pom.xml, line 146, column 21

[ERROR]     'dependencies.dependency.version' for org.lwjgl:lwjgl-glfw:jar:${lwjgl.natives} is missing. @ org.phoenicis:phoenicis-tools:[unknown-version], /Users/travis/build/PhoenicisOrg/phoenicis/phoenicis-tools/pom.xml, line 151, column 21

[ERROR]     'dependencies.dependency.version' for org.lwjgl:lwjgl-opengl:jar:${lwjgl.natives} is missing. @ org.phoenicis:phoenicis-tools:[unknown-version], /Users/travis/build/PhoenicisOrg/phoenicis/phoenicis-tools/pom.xml, line 156, column 21

Again I just copy-paste the pom.xml from lwjgl website

plata · 2019-12-28T12:40:37Z

What's the status here?

ImperatorS79 · 2019-12-28T16:22:22Z

I do not know why the macOS build fails. The lines added to the pom come directly from lwjgl website, and it works on linux.

plata · 2019-12-28T18:49:48Z

@qparis could you check the Mac OS build?

qparis · 2019-12-28T19:41:30Z

Ok, I'll have a look once I have managed to build wine 32on64. This is a difficult task that is taking most of the time I'm devoting to Phoenicis at the moment

ImperatorS79 · 2020-01-10T19:33:58Z

Ok I think I found where the error came from. Arch for macos is x86_64 instead of amd64. Which lwjgl website did not mention.

plata · 2020-02-17T10:51:49Z

What's the state of this pr?

ImperatorS79 · 2020-02-17T12:23:36Z

It compiles everywhere and works under linux. Needs to be tested on macos.

madoar · 2020-02-17T19:25:52Z

It compiles everywhere and works under linux. Needs to be tested on macos.

I think it may be worth it to just merge this as is. If later on someone can test it on mac and finds out that it does not work it is still not too late to add a separate solution for macos. @plata what do you think?

plata · 2020-02-17T20:18:38Z

It's fine for me.

ImperatorS79 added 8 commits January 21, 2019 21:59

Merge pull request #1 from PhoenicisOrg/master

13691a3

Merge master

Merge pull request #2 from PhoenicisOrg/master

ff9b79c

Merge master

Update pom.xml

0774f93

Add files via upload

1610c5e

Update ToolsConfiguration.java

0adb378

Update GraphicsProperties.java

f9095d5

Update GraphicsPropertiesFetcher.java

ec9a3ef

Update GraphicsPropertiesFetcher.java

3e6eeab

Update GraphicsPropertiesFetcher.java

a424044

Fix OpenGL library not being loadable multiple times

090bd4e

ImperatorS79 added 2 commits August 25, 2019 13:01

Update GraphicsProperties.java

1d5b026

Update GraphicsPropertiesFetcher.java

cd869f3

madoar requested changes Aug 25, 2019

View reviewed changes

Update GraphicsProperties.java

e3bb0f8

ImperatorS79 added 4 commits August 25, 2019 16:53

Update GraphicsProperties.java

121ae07

Update GraphicsPropertiesFetcher.java

7cb22be

Update GraphicsPropertiesFetcher.java

2030616

Fix travis and tr

3678f8f

Also fetch core context Version

1d70003

Update GraphicsPropertiesFetcher.java

f40bf65

ImperatorS79 added 2 commits September 6, 2019 13:56

Update GraphicsProperties.java

5d50f1c

Update GraphicsPropertiesFetcher.java

62faa23

ImperatorS79 added 3 commits October 3, 2019 21:42

Update GraphicsPropertiesFetcher.java

0d1559c

Merge pull request #3 from PhoenicisOrg/master

10ddec0

Merge master

It builds

35e9b1e

ImperatorS79 added 2 commits October 5, 2019 10:52

Update pom.xml

8ebc6ca

Update pom.xml

a50e013

Test

36b1b4f

Add a GraphicsPropertiesFetcher class #2071

Are you sure you want to change the base?

Add a GraphicsPropertiesFetcher class #2071

Conversation

ImperatorS79 commented Aug 25, 2019

ImperatorS79 commented Aug 25, 2019

ImperatorS79 commented Aug 25, 2019 • edited Loading

ImperatorS79 commented Aug 25, 2019

ImperatorS79 commented Aug 25, 2019

madoar Aug 25, 2019

Choose a reason for hiding this comment

ImperatorS79 Aug 25, 2019 • edited Loading

Choose a reason for hiding this comment

ImperatorS79 Aug 25, 2019

Choose a reason for hiding this comment

madoar Aug 26, 2019

Choose a reason for hiding this comment

ImperatorS79 Aug 26, 2019

Choose a reason for hiding this comment

madoar Aug 27, 2019

Choose a reason for hiding this comment

madoar commented Aug 25, 2019

ImperatorS79 commented Aug 25, 2019

ImperatorS79 commented Aug 25, 2019

madoar commented Aug 25, 2019

ImperatorS79 commented Aug 25, 2019

ImperatorS79 commented Aug 27, 2019 • edited Loading

Zemogiter commented Aug 27, 2019

ImperatorS79 commented Oct 3, 2019

madoar commented Oct 3, 2019

ImperatorS79 commented Oct 3, 2019

madoar commented Oct 3, 2019

ImperatorS79 commented Oct 3, 2019 • edited Loading

madoar commented Oct 3, 2019

ImperatorS79 commented Oct 3, 2019

madoar commented Oct 3, 2019

madoar commented Oct 3, 2019

ImperatorS79 commented Oct 4, 2019

madoar commented Oct 5, 2019

ImperatorS79 commented Oct 5, 2019 • edited Loading

plata commented Dec 28, 2019

ImperatorS79 commented Dec 28, 2019

plata commented Dec 28, 2019

qparis commented Dec 28, 2019

ImperatorS79 commented Jan 10, 2020

plata commented Feb 17, 2020

ImperatorS79 commented Feb 17, 2020

madoar commented Feb 17, 2020

plata commented Feb 17, 2020

ImperatorS79 commented Aug 25, 2019 •

edited

Loading

ImperatorS79 Aug 25, 2019 •

edited

Loading

ImperatorS79 commented Aug 27, 2019 •

edited

Loading

ImperatorS79 commented Oct 3, 2019 •

edited

Loading

ImperatorS79 commented Oct 5, 2019 •

edited

Loading