add fakeroot to dockerfile = successful building on gitpod.io #2371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plata
reviewed
Mar 8, 2021
| mvn exec:java | ||
| mvn clean package && | ||
| cd phoenicis-dist/src/scripts && | ||
| sh phoenicis-create-package.sh |
There was a problem hiding this comment.
This way you can only build the package but not run it to test your code changes (which should be the main purpose for gitpod).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't get this to compile on gitpod because it was lacking fakeroot. Also, the original does something in the subfolder javafx. The build guide here says to run a bash script in the phoenicis-dist/src/scripts folder, so I changed the yml file too. It now produces a very installable .deb file.
Instead of USER root, it's also possible to run sudo in the dockerfile. Not sure if it really matters at this point in time.
reference -- here they say not to use USER root, but then they link you to this example, which uses USER root... so...?
Last but not least, as of this post you can now enable sudo in new workspaces by enabling 'Feature Preview' in settings, but that's rather round-about to fix a missing package.