Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xyk_pool, stable_pool: withdraw_liquidity - min_a, min_b validation #435

Merged
merged 1 commit into from
Feb 13, 2025
Merged

xyk_pool, stable_pool: withdraw_liquidity - min_a, min_b validation #435

merged 1 commit into from
Feb 13, 2025

Conversation

gangov
Copy link
Collaborator

@gangov gangov commented Feb 11, 2025

now we check if min_a and min_b is only less than 0

@gangov
xyk_pool, stable_pool: withdraw_liquidity - min_a, min_b validation
2e80c12 
now we check if `min_a` and `min_b` is only less than 0
@gangov gangov self-assigned this Feb 11, 2025
@gangov gangov linked an issue Feb 11, 2025 that may be closed by this pull request
Pair: Allow 0 as min_a and min_b parameters #91
Closed
@gangov gangov requested a review from ueco-jb February 11, 2025 10:16
ueco-jb
ueco-jb approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Although I would check if this validate_int_parameters macro is still needed in that case.

@gangov
Copy link
Collaborator Author

gangov commented Feb 13, 2025

I think it's okay to keep the macro for now - it's being used in 2 other functions and one of these - provide_liquidity is validating more than one argument.

@gangov gangov merged commit b886512 into main Feb 13, 2025
3 checks passed
@gangov gangov deleted the 91-pair-allow-0-as-min_a-and-min_b-parameters branch February 13, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ueco-jb ueco-jb ueco-jb approved these changes

Assignees

@gangov gangov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pair: Allow 0 as min_a and min_b parameters
2 participants
@gangov @ueco-jb