Calibration stream resolution, stream resolution warning, divisor 8x #1671
+79
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You chose to put the warning separate from the drop-down so you don't have to scroll down right? Generally it's good to keep the warning adjacent to the thing it's warning about. |
|
Correct. I wanted it to be visible. |
|
I'll defer to others on UX, but Lgtm |
mcm001
reviewed
Jan 3, 2025
| const isStreamResolutionTooHigh = computed(() => { | ||
| const currentResolution = useCameraSettingsStore().currentVideoFormat.resolution; | ||
| const divisor = streamDivisors[useCameraSettingsStore().currentPipelineSettings.streamingFrameDivisor]; | ||
| return currentResolution.width / divisor > 320 || currentResolution.height / divisor > 240; |
There was a problem hiding this comment.
How did we decide on this upper limit? Vibes? Document the magic numbers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are not able to do this with chessboard at this time since we use the framedivisor for decimation. This also adds a warning for resolutions over 320x240. Finally, it adds an 8x divisor.
also fixes #1501