-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change RKNN default core mask to all cores #1744
base: main
Are you sure you want to change the base?
Conversation
Can you share some testing data that supports this? |
I'm currently having trouble testing with the latest PV build (camera disconnects, camera feed looks pink for OV9782). Fwiw, that's what we've found to be the only real difference between the high-performance fork, which for us had more fps and less latency. |
Can this setting be changed in the dashboard at all? |
Can be done, though this is defined on init as far as I see. |
Given that the performance of multiple cameras is worse, it might be desirable to have it as a toggle for teams wishing to run multiple pipelines. If you do decide to add it, I would suggest putting it under the Object Detection card in the settings. |
I agree with Sam but would also say we need to add docs information documenting this testing so people can make an informed decision on what to select for their usecase. Happy to default on this though |
I'd love to add it as some kind of toggle button, I'm just not so sure on how to do it, especially considering this is set on init. Do you have any pointers? |
You could either change the rknn JNI repo to allow setting it at runtime or recreate it when the option is changed |
Just found I can use this. I'll try to see how I add something you can select from. |
All seems to work, would love a CR. |
v-model="currentPipelineSettings.useAllCores" | ||
label="Use All Cores" | ||
:label-cols="4" | ||
tooltip="Enables or Disables using all the cores of the NPU. When on, this might yield faster results for one camera, but slower/more unstable results for multiple cameras. Might take a few seconds to take effect, or require a restart." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a docs section on neural networks? if so we should add that there as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah we do, it's about object detection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This behaviour should be documented there
Logic generally looks good but I don't have any hardware I can test this on |
Any config change available in the interim to make this the default (w/ out PR)? |
You can always grab the build from this PR. Afaik, there are no config options other than that. |
No, this PR adds a config option |
After some testing, we've found that using all cores all the time is the fastest option, even when running more than one object detection pipeline simultaneously. This is using
RKNN_NPU_CORE_0_1_2
instead ofRKNN_NPU_CORE_AUTO