feat: add metrics publisher for NT #1791
Conversation
|
Also add a way to toggle this in settings. |
Nah. Keep it on. IMO this kind of participant metrics could be good to have as a NT protocol extnesion |
| @@ -129,6 +129,24 @@ public String getIpAddress() { | |||
| return addr; | |||
| } | |||
|
|
|||
| public HashMap<String, String> getMetrics() { | |||
| HashMap<String, String> metrics = new HashMap<String, String>(); | |||
There was a problem hiding this comment.
What drove you to use a HashMap here? It looks like this code is duplicated from publishMetrics. Can we switch both to a Jackson serializable Java POD class? And we might consider a NT struct here as well.
There was a problem hiding this comment.
I just used a hashmap cause we use it in the publishMetrics as well. When you say NT struct, do you mean like a subtable?
There was a problem hiding this comment.
There was a problem hiding this comment.
I also think a hashmap might be the best option as it lets us easily iterate through everything
There was a problem hiding this comment.
I think a struct is the best option for publishing to NT then a shared type between photonlib and the backend for accessing the data
this might work, but it still needs testing.
we don't know if it actually publishes, also don't know how much resources this'll consume