S3 pre-signed URL: error with unicode filename catalyst#455

PhucNguyen0311 · Dec 20, 2021 · 755396d · 755396d
1 parent 35951fd
commit 755396d
Showing 1 changed file with 12 additions and 1 deletion.
diff --git a/classes/local/store/s3/client.php b/classes/local/store/s3/client.php
@@ -460,7 +460,18 @@ private function generate_presigned_url_s3($contenthash, $headers) {
 
         $contentdisposition = manager::get_header($headers, 'Content-Disposition');
         if ($contentdisposition !== '') {
-            $params['ResponseContentDisposition'] = $contentdisposition;
+            $fparts = explode('; ', $contentdisposition);
+            if (!empty($fparts[1])) {
+                $originalfilename = str_replace('filename=', '', $fparts[1]); // Get the actual filename.
+                $originalfilename = str_replace('"', '', $originalfilename); // Remove the quotes.
+            }
+            if (!empty($fparts[0])) {
+                $contentdisposition = $fparts[0];
+            }
+            if (!empty($originalfilename)) {
+                $newcontentdisposition = $contentdisposition . '; ' . 'filename="' . utf8_encode($originalfilename) . '"';
+                $params['ResponseContentDisposition'] = $newcontentdisposition;
+            }
         }
 
         $contenttype = manager::get_header($headers, 'Content-Type');