Suggestions

PicnicSupermarket · Oct 9, 2023 · f9f7d25 · f9f7d25
1 parent d0c17b8
commit f9f7d25
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 28 deletions.
diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ReactorRules.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ReactorRules.java
@@ -988,34 +988,26 @@ Flux<S> after(Flux<T> flux) {
   /** Prefer {@link Mono#ofType(Class)} over more contrived alternatives. */
   static final class MonoOfType<T, S> {
     @BeforeTemplate
-    Mono<S> before(Mono<T> mono) {
-      return mono.filter(
-              Refaster.anyOf(
-                  Refaster.<S>clazz()::isInstance,
-                  x -> Refaster.<S>clazz().isAssignableFrom(x.getClass())))
-          .cast(Refaster.<S>clazz());
+    Mono<S> before(Mono<T> mono, Class<S> clazz) {
+      return mono.filter(clazz::isInstance).cast(clazz);
     }
 
     @AfterTemplate
-    Mono<S> after(Mono<T> mono) {
-      return mono.ofType(Refaster.<S>clazz());
+    Mono<S> after(Mono<T> mono, Class<S> clazz) {
+      return mono.ofType(clazz);
     }
   }
 
   /** Prefer {@link Flux#ofType(Class)} over more contrived alternatives. */
   static final class FluxOfType<T, S> {
     @BeforeTemplate
-    Flux<S> before(Flux<T> flux) {
-      return flux.filter(
-              Refaster.anyOf(
-                  Refaster.<S>clazz()::isInstance,
-                  x -> Refaster.<S>clazz().isAssignableFrom(x.getClass())))
-          .cast(Refaster.<S>clazz());
+    Flux<S> before(Flux<T> flux, Class<S> clazz) {
+      return flux.filter(clazz::isInstance).cast(clazz);
     }
 
     @AfterTemplate
-    Flux<S> after(Flux<T> flux) {
-      return flux.ofType(Refaster.<S>clazz());
+    Flux<S> after(Flux<T> flux, Class<S> clazz) {
+      return flux.ofType(clazz);
     }
   }
 

diff --git a/...ontrib/src/test/resources/tech/picnic/errorprone/refasterrules/ReactorRulesTestInput.java b/...ontrib/src/test/resources/tech/picnic/errorprone/refasterrules/ReactorRulesTestInput.java
@@ -333,16 +333,12 @@ Flux<Number> testFluxCast() {
     return Flux.just(1).map(Number.class::cast);
   }
 
-  ImmutableSet<Mono<Number>> testMonoOfType() {
-    return ImmutableSet.of(
-        Mono.just(1).filter(Number.class::isInstance).cast(Number.class),
-        Mono.just(2).filter(n -> Number.class.isAssignableFrom(n.getClass())).cast(Number.class));
+  Mono<Number> testMonoOfType() {
+    return Mono.just(1).filter(Number.class::isInstance).cast(Number.class);
   }
 
-  ImmutableSet<Flux<Number>> testFluxOfType() {
-    return ImmutableSet.of(
-        Flux.just(1).filter(Number.class::isInstance).cast(Number.class),
-        Flux.just(2).filter(n -> Number.class.isAssignableFrom(n.getClass())).cast(Number.class));
+  Flux<Number> testFluxOfType() {
+    return Flux.just(1).filter(Number.class::isInstance).cast(Number.class);
   }
 
   Mono<String> testMonoFlatMap() {

diff --git a/...ntrib/src/test/resources/tech/picnic/errorprone/refasterrules/ReactorRulesTestOutput.java b/...ntrib/src/test/resources/tech/picnic/errorprone/refasterrules/ReactorRulesTestOutput.java
@@ -326,12 +326,12 @@ Flux<Number> testFluxCast() {
     return Flux.just(1).cast(Number.class);
   }
 
-  ImmutableSet<Mono<Number>> testMonoOfType() {
-    return ImmutableSet.of(Mono.just(1).ofType(Number.class), Mono.just(2).ofType(Number.class));
+  Mono<Number> testMonoOfType() {
+    return Mono.just(1).ofType(Number.class);
   }
 
-  ImmutableSet<Flux<Number>> testFluxOfType() {
-    return ImmutableSet.of(Flux.just(1).ofType(Number.class), Flux.just(2).ofType(Number.class));
+  Flux<Number> testFluxOfType() {
+    return Flux.just(1).ofType(Number.class);
   }
 
   Mono<String> testMonoFlatMap() {