Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce AssertThatPathContent{,Utf8} Refaster rules #530

Merged
merged 2 commits into from
Mar 20, 2023
Merged

Introduce AssertThatPathContent{,Utf8} Refaster rules #530

merged 2 commits into from
Mar 20, 2023

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Mar 12, 2023 •
edited
Loading

Identified while reviewing #494.

Suggested commit message:

Introduce `AssertThatPathContent{,Utf8}` Refaster rules (#530)

@Stephan202 Stephan202 added this to the 0.9.0 milestone Mar 12, 2023
@Stephan202 Stephan202 requested a review from rickie March 12, 2023 15:50
@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

1 similar comment
@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

rickie
rickie approved these changes Mar 19, 2023
View reviewed changes
Copy link
Member

@rickie rickie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement 🚀 !

@rickie rickie requested a review from werli March 19, 2023 14:53
@rickie rickie force-pushed the sschroevers/refaster-AssertThatPathContent-rules branch from 72d4d6e to 225baf0 Compare March 19, 2023 14:53
@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

werli
werli approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@werli werli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I'd merge if I had permissions. Feel free to do so.

@rickie rickie merged commit d30c99a into master Mar 20, 2023
@rickie rickie deleted the sschroevers/refaster-AssertThatPathContent-rules branch March 20, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@werli werli werli approved these changes

@rickie rickie rickie approved these changes

Assignees
No one assigned
Labels
new feature
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Stephan202 @werli @rickie