Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce TypeMemberOrder bug checker #636

Open
wants to merge 49 commits into
base: master
Choose a base branch
from
Open

Introduce TypeMemberOrder bug checker #636

wants to merge 49 commits into from
+1,142 −0

Commits on May 24, 2024

  1. Naive impl

    @benhalasi @rickie
    benhalasi authored and rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    b4fb38e View commit details
    Browse the repository at this point in the history

  2. Consider comments

    @benhalasi @rickie
    benhalasi authored and rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    33ce27c View commit details
    Browse the repository at this point in the history

  3. Prepare the code for others to see 

     - kinda cleanup `replaceIncludingComments` copy
 - mark unsure parts of the code
 - list remaining tasks
    @benhalasi @rickie
    benhalasi authored and rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    e96bc33 View commit details
    Browse the repository at this point in the history

  4. Test if error message contains crucial information

    @benhalasi @rickie
    benhalasi authored and rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    29d7413 View commit details
    Browse the repository at this point in the history

  5. Code clean-up, formatting, docs, TEMPORARY supress warnings

    @benhalasi @rickie
    benhalasi authored and rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    cf72d2d View commit details
    Browse the repository at this point in the history

  6. Cannot verify whitespace related requirements as `TestMode.TEXT_MATCH… 

    …` formats the sources
    @benhalasi @rickie
    benhalasi authored and rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    2d24bcb View commit details
    Browse the repository at this point in the history

  7. Apply my suggestions 

    - phrasing: last , -> and
- Reasonably concise `COMPARATOR` and its docs
    @benhalasi @rickie
    benhalasi authored and rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    35b23a8 View commit details
    Browse the repository at this point in the history

  8. Suggestions

    @rickie
    rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    66422b8 View commit details
    Browse the repository at this point in the history

  9. Drop replaceIncludingComments

    @rickie
    rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    2982aea View commit details
    Browse the repository at this point in the history

  10. Revert "Drop replaceIncludingComments" 

    This reverts commit 133c85d.
    @rickie
    rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    5ce0323 View commit details
    Browse the repository at this point in the history

  11. Suggestions

    @benhalasi @rickie
    benhalasi authored and rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    86c3fbb View commit details
    Browse the repository at this point in the history

  12. Checkstyle

    @benhalasi @rickie
    benhalasi authored and rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    9e2904e View commit details
    Browse the repository at this point in the history

  13. suggestions

    @oxkitsune @rickie
    oxkitsune authored and rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    26e84ea View commit details
    Browse the repository at this point in the history

  14. Remove stray unused import

    @oxkitsune @rickie
    oxkitsune authored and rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    5d09ad9 View commit details
    Browse the repository at this point in the history

  15. Simplifing logic, killing mutants

    @benhalasi @rickie
    benhalasi authored and rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    c972d8c View commit details
    Browse the repository at this point in the history

  16. "Fix" previous token detection

    @benhalasi @rickie
    benhalasi authored and rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    2f36711 View commit details
    Browse the repository at this point in the history

  17. Assume that only generated members' end position is unavailable.

    @benhalasi @rickie
    benhalasi authored and rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    b961243 View commit details
    Browse the repository at this point in the history

  18. Suggestions on naming, minor organizational changes, rewordings

    @benhalasi @rickie
    benhalasi authored and rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    eeffb3e View commit details
    Browse the repository at this point in the history

  19. Reproduce error-prone token start - end position overlap

    @benhalasi @rickie
    benhalasi authored and rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    45d91bd View commit details
    Browse the repository at this point in the history

  20. Suggestions

    @Stephan202 @rickie
    Stephan202 authored and rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    314ae20 View commit details
    Browse the repository at this point in the history

  21. List all remarks as TODOs, or address them

    @benhalasi @rickie
    benhalasi authored and rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    894db81 View commit details
    Browse the repository at this point in the history

  22. Rename *class* to *type*

    @benhalasi @rickie
    benhalasi authored and rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    468d1a3 View commit details
    Browse the repository at this point in the history

  23. Add identification test for an empty class, sync identifaction test w… 

    …/ new error message
    @benhalasi @rickie
    benhalasi authored and rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    63e69db View commit details
    Browse the repository at this point in the history

  24. Verify that SupressWarnings("all" or "TypeMemberOrdering") are not or… 

    …dered
    @benhalasi @rickie
    benhalasi authored and rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    4e3fc59 View commit details
    Browse the repository at this point in the history

  25. Suggestions

    @benhalasi @rickie
    benhalasi authored and rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    6aa5ae4 View commit details
    Browse the repository at this point in the history

  26. Test initializer block ordering

    @benhalasi @rickie
    benhalasi authored and rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    0c9e835 View commit details
    Browse the repository at this point in the history

  27. Implement initializer block ordering

    @benhalasi @rickie
    benhalasi authored and rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    26fa451 View commit details
    Browse the repository at this point in the history

  28. Test inner type ordering

    @benhalasi @rickie
    benhalasi authored and rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    dd6ab5b View commit details
    Browse the repository at this point in the history

  29. Implement inner type ordering

    @benhalasi @rickie
    benhalasi authored and rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    97562ca View commit details
    Browse the repository at this point in the history

  30. Test not-ordering unordered members annotated w/ SuppressWarnings

    @benhalasi @rickie
    benhalasi authored and rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    48c9cf3 View commit details
    Browse the repository at this point in the history

  31. Stop sorting unsorted members annotated w/ SuppressWarnings - all or … 

    …TypeMemberOrdering
    @benhalasi @rickie
    benhalasi authored and rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    8cedd99 View commit details
    Browse the repository at this point in the history

  32. Rename TypeMemberWithComments to TypeMember

    @benhalasi @rickie
    benhalasi authored and rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    f90fb63 View commit details
    Browse the repository at this point in the history

  33. Support classes, interfaces and enums

    @benhalasi @rickie
    benhalasi authored and rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    9080a42 View commit details
    Browse the repository at this point in the history

  34. Post rebase fix

    @rickie
    rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    e419129 View commit details
    Browse the repository at this point in the history

  35. Pair programming session

    @rickie
    rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    b831e5a View commit details
    Browse the repository at this point in the history

  36. Test abstract and default methods

    @benhalasi @rickie
    benhalasi authored and rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    9d24bb4 View commit details
    Browse the repository at this point in the history

  37. Tweaks

    @benhalasi @rickie
    benhalasi authored and rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    fc8d1ff View commit details
    Browse the repository at this point in the history

  38. Suggestions

    @rickie
    rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    63a187a View commit details
    Browse the repository at this point in the history

  39. Improve more tests

    @rickie
    rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    84685d9 View commit details
    Browse the repository at this point in the history

  40. Reproduce syntactically wrong replacement with annotations containing… 

    … `LBRACE`
    @benhalasi @rickie
    benhalasi authored and rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    c0a8b15 View commit details
    Browse the repository at this point in the history

  41. Fix syntactically wrong replecement with annotations containing LBRACE

    @benhalasi @rickie
    benhalasi authored and rickie committed May 24, 2024
    Configuration menu
    Copy the full SHA
    8d2c426 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. Suggestions

    @rickie
    rickie committed May 27, 2024
    Configuration menu
    Copy the full SHA
    8c83401 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Suggestions part 1

    @rickie
    rickie committed May 30, 2024
    Configuration menu
    Copy the full SHA
    ce62e7e View commit details
    Browse the repository at this point in the history

  2. Try to implement new thing

    @rickie
    rickie committed May 30, 2024
    Configuration menu
    Copy the full SHA
    55416f7 View commit details
    Browse the repository at this point in the history

  3. Final suggestions, but three failing tests

    @rickie
    rickie committed May 30, 2024
    Configuration menu
    Copy the full SHA
    588a3e7 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2024

  1. Move TypeMemberOrder BugChecker into experimental module

    @benhalasi
    benhalasi committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    8c0cd45 View commit details
    Browse the repository at this point in the history

  2. Fix & enable TypeMemberOrderEnumTest

    @benhalasi
    benhalasi committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    50ee382 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Cleanup

    @rickie
    rickie committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    e6ffb44 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Pair programming

    @rickie
    rickie committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    21878aa View commit details
    Browse the repository at this point in the history