Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade com.google.truth:truth 1.0.1 -> 1.1.3 #78

Merged
merged 2 commits into from
Jun 5, 2022
Merged

Upgrade com.google.truth:truth 1.0.1 -> 1.1.3 #78

merged 2 commits into from
Jun 5, 2022

Conversation

Picnic-Bot
Copy link
Contributor

@Picnic-Bot Picnic-Bot commented Apr 25, 2022 •
edited
Loading

This PR contains the following updates:

Package Type Update Change
com.google.truth:truth compile minor 1.0.1 -> 1.1.3
  • If you want to rebase/retry this PR, click this checkbox.

@Picnic-Bot
Copy link
Contributor Author

Picnic-Bot commented Apr 25, 2022 •
edited by rickie
Loading

Suggested commit message:

Upgrade Truth 1.0.1 -> 1.1.3 (#78)

See:
- https://github.com/google/truth/releases/tag/release_1_1
- https://github.com/google/truth/releases/tag/release_1_1_1
- https://github.com/google/truth/releases/tag/release_1_1_2
- https://github.com/google/truth/releases/tag/release_1_1_3
- https://github.com/google/truth/compare/release_1_0_1...release_1_1_3

@Stephan202
Copy link
Member

This breaks "something" in RefasterCheckTest. I have looked into this in the past, but back then didn't spot the issue. Perhaps we should first try to upgrade Truth in Error Prone itself; perhaps that'll give a clue.

@Picnic-Bot Picnic-Bot force-pushed the renovate/com.google.truth-truth-1.x branch 3 times, most recently from ac0d789 to 1b2fb91 Compare May 2, 2022 06:01
@Picnic-Bot Picnic-Bot force-pushed the renovate/com.google.truth-truth-1.x branch 2 times, most recently from 2a18c7d to bb8ac13 Compare May 18, 2022 06:01
@Picnic-Bot Picnic-Bot force-pushed the renovate/com.google.truth-truth-1.x branch 2 times, most recently from af7ffb4 to 0b06798 Compare May 27, 2022 06:01
@Picnic-Bot Picnic-Bot force-pushed the renovate/com.google.truth-truth-1.x branch 2 times, most recently from 736f0bb to febd0b5 Compare June 2, 2022 06:01
@Stephan202 Stephan202 force-pushed the renovate/com.google.truth-truth-1.x branch from febd0b5 to b4c441e Compare June 5, 2022 10:22
@Stephan202 Stephan202 added this to the 0.1.0 milestone Jun 5, 2022
Stephan202
Stephan202 approved these changes Jun 5, 2022
View reviewed changes
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a commit to fix the build. Would like to merge this before #43, so that there we don't need to upgrade Truth in that PR.

Stephan202
Stephan202 reviewed Jun 5, 2022
View reviewed changes
error-prone-contrib/pom.xml
Comment on lines +129 to +133
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<scope>test</scope>
</dependency>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This merely makes explicit a preexisting dependency on JUnit 4. See also google/truth#333. In #43 this dependency will become implicit again. Avoiding it altogether can be the topic of a separate PR.)

@Stephan202 Stephan202 requested a review from rickie June 5, 2022 10:39
rickie
rickie approved these changes Jun 5, 2022
View reviewed changes
Copy link
Member

@rickie rickie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@rickie
Copy link
Member

rickie commented Jun 5, 2022

Don't we want the truth to start with a capitalized letter? I can open a PR for that 😄. It's also how they call Truth themselves.

@Stephan202
Copy link
Member

Good one; yes, let's!

@Stephan202 Stephan202 merged commit 0a63361 into master Jun 5, 2022
@Stephan202 Stephan202 deleted the renovate/com.google.truth-truth-1.x branch June 5, 2022 18:52
@rickie
Copy link
Member

rickie commented Jun 6, 2022

In: https://github.com/PicnicSupermarket/picnic-renovate/pull/97

@rickie rickie mentioned this pull request Jun 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stephan202 Stephan202 Stephan202 approved these changes

@rickie rickie rickie approved these changes

Assignees
No one assigned
Labels
dependencies
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Picnic-Bot @Stephan202 @rickie