Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply assorted build improvements #866

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Apply assorted build improvements #866

merged 1 commit into from
Nov 27, 2023

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Oct 29, 2023 •
edited
Loading

Suggested commit message:

Apply assorted build improvements (#866)

Summary of changes:
- Consistently use `.yml` instead of `.yaml`.
- Don't install SNAPSHOT artifacts during the CodeQL build, so that
  they don't end up in the Maven cache.
- Sync a bunch of `pom.xml` changes from our internal Maven parent.

@Stephan202 Stephan202 added this to the 0.15.0 milestone Oct 29, 2023
@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie self-requested a review October 30, 2023 06:36
@Stephan202 Stephan202 force-pushed the sschroevers/assorted-build-improvements branch from cd37b07 to c06d449 Compare November 6, 2023 09:34
@Stephan202
Copy link
Member Author

GitHub reported conflicts, but locally rebasing worked fine (likely due to a different merge strategy). Pushed.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie force-pushed the sschroevers/assorted-build-improvements branch from c06d449 to 448b5b1 Compare November 23, 2023 13:26
@rickie rickie added the chore A task not related to code (build, formatting, process, ...) label Nov 23, 2023
@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

mohamedsamehsalah
mohamedsamehsalah approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@mohamedsamehsalah mohamedsamehsalah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean 🧹

@rickie rickie force-pushed the sschroevers/assorted-build-improvements branch from 448b5b1 to d5740ef Compare November 27, 2023 07:56
@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rickie
Copy link
Member

rickie commented Nov 27, 2023

Do we want to include the summary of changes in the commit message?

@Stephan202
Copy link
Member Author

@rickie indeed! Tweaked it.

@rickie rickie merged commit eafb738 into master Nov 27, 2023
17 checks passed
@rickie rickie deleted the sschroevers/assorted-build-improvements branch November 27, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickie rickie rickie approved these changes

@mohamedsamehsalah mohamedsamehsalah mohamedsamehsalah approved these changes

Assignees
No one assigned
Labels
chore A task not related to code (build, formatting, process, ...)
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Stephan202 @rickie @mohamedsamehsalah