Fix SqliteConnector always returning valid beatmap objects

Will now return null when beatmap cant be found.
Piotrekol · Sep 27, 2016 · 7ddbc45 · 7ddbc45
1 parent 8fe4432
commit 7ddbc45
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/osu!StreamCompanion/Code/Core/SqliteConnector.cs b/osu!StreamCompanion/Code/Core/SqliteConnector.cs
@@ -223,25 +223,25 @@ private void FillBeatmapParameters(Beatmap beatmap)
 
         }
         public Beatmap GetBeatmap(int mapId)
-        {//mapId should be >0
-
+        {
             string sql = "SELECT * FROM `withID` WHERE MapId = " + mapId;
             var reader = Query(sql);
-            var beatmap = new Beatmap();
+            Beatmap beatmap = null;
 
             if (reader.Read())
             {
+                beatmap = new Beatmap();
                 beatmap.Read(reader);
             }
             else
             {
                 reader.Dispose();
                 sql = "SELECT * FROM `Temp` WHERE MapId = " + mapId;
                 reader = Query(sql);
-                beatmap = new Beatmap();
 
                 if (reader.Read())
                 {
+                    beatmap = new Beatmap();
                     beatmap.Read(reader);
                 }
                 reader.Dispose();

diff --git a/osu!StreamCompanion/Code/Core/SqliteControler.cs b/osu!StreamCompanion/Code/Core/SqliteControler.cs
@@ -103,7 +103,7 @@ public void StoreTempBeatmap(Beatmap beatmap)
         /// 
         /// </summary>
         /// <param name="mapId"></param>
-        /// <returns>Beatmap object with filled or not map data (use mapId property as check if data is set)</returns>
+        /// <returns>Beatmap object with data, or null on not found</returns>
         public Beatmap GetBeatmap(int mapId)
         {
             lock (_sqlConnector)