Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete refresh #49

Merged
merged 17 commits into from
Mar 3, 2022
Merged

Complete refresh #49

merged 17 commits into from
Mar 3, 2022

Conversation

soundstorm
Copy link

@soundstorm soundstorm commented Jun 16, 2020

Allow call to get ID of public room (channel) or user; bump to 1.2.15
Will allow better code for fraschetti/Octoslack#93
Closes #46 as getting the id is now possible (but still not without auth).
Allow to create private rooms, invite users to rooms/channels (closes #35)
Complete documentation in README (closes #38 and closes #48)

Allow call to get ID of public room (channel) or user
@soundstorm
Copy link
Author

Although the call of get_room_id (and set_room_topic too) to acquire the id of a group instead of a channel is misleading, as get_room_history is a call on channels, but would be a breaking change otherwise.
Maybe this could be a cleanup for further releases?
Or add an alias for them like get_private_room_id, set_private_room_topic, get_public_room_history and deprecate the others.

@soundstorm soundstorm changed the title Add method to get User/Channel ID Complete refresh Jul 4, 2020
@soundstorm
Copy link
Author

Hey @pipozzz can you have a look? Closed most of your open issues and made a few enhancements.

@pipozzz
Copy link
Member

pipozzz commented Jul 17, 2020

I'm a little busy right now, but definitely I'll review it and let you know. Thanks for contribution.

setup.py Outdated Show resolved Hide resolved
.bumpversion.cfg Outdated Show resolved Hide resolved
Co-authored-by: Peter Gonda <[email protected]>
AUTHORS.txt Outdated
@@ -1,3 +1,4 @@
Derek Stegelman - dstegelman
Jorge Alberto Díaz Orozco - jadolg
cesarandreslopez
Luca Zimmermann - soundstorm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, do not touch AUTHORS.txt, I'm planning to create CONTRIBUTORS.txt file which better describe its purpose.

rocketchat/calls/channels/invite_public_room.py Outdated Show resolved Hide resolved
@pipozzz
Copy link
Member

pipozzz commented Aug 17, 2020

Also we need to resolve failed build before merging, btw Thanks for your contribution again ! 👍

Co-authored-by: Peter Gonda <[email protected]>
@GrabsOrion
Copy link

Hello, @soundstorm!
Are you planning to fix the failed build?
As much as I know, the message from Travis CI not so crucial:

'rocketchat.calls.groups.upload_remote_file.UploadRemoteFile' imported but unused

I'm very new to programming, but interested in the project, thank you!

@pipozzz
Copy link
Member

pipozzz commented Mar 11, 2021

It seems that code is OK just test coverage dropped below 85%.

@pipozzz pipozzz changed the base branch from master to refresh March 3, 2022 12:32
@pipozzz pipozzz merged commit 4f88851 into Pipoline:refresh Mar 3, 2022
@soundstorm
Copy link
Author

This is still in the refresh branch after two years, will there be a release with those changes anytime?

@pipozzz
Copy link
Member

pipozzz commented Feb 29, 2024

Hi @soundstorm, I was very busy, but Yes I'll review it and merge it if it's fine. There was failed some test last time I took a look. So let me check it again and merge it if it's fine. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants