Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared examples #1280

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

tdaffin
Copy link
Contributor

@tdaffin tdaffin commented May 26, 2019

Kind of a speculative PR here, where I'm trying to achieve a few goals:

  • Make the shared example code more readable by breaking it up into a bunch of sub modules
  • Make it easier to add new examples to the shared examples without having to change any of the backends
  • Separate the Ids into a bunch of smaller structs so that simple names like 'button' can be used in each

I'd like to move some of the examples from conrod_glium into shared examples, and I think that this restructuring will make that easier.

I think that it would perhaps also be useful to add something like a non scrolling menu bar at the top of the shared examples. This menu could have controls that allow sections of the shared examples to be dynamically swapped out. It could perhaps also allow the sections to be displayed in different contexts like tabs, or in scrolling. I expect that contextual problems like scissor rectangles could then be more easily reproduced.

@tdaffin
Copy link
Contributor Author

tdaffin commented May 31, 2019

I've been continuing development on top of this branch (https://github.com/tdaffin/conrod/tree/move_examples - not ready for PR yet), and as a result I think perhaps calling all the structs that hold ids 'Gui' isn't such a great idea.
I'm not entirely sure what would be a better name -- perhaps something like 'Widgets' ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant