Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning #1428

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix warning #1428

wants to merge 3 commits into from

Conversation

muzudho
Copy link

@muzudho muzudho commented Jun 23, 2021

warning: anonymous parameters are deprecated and will be removed in the next edition.

warning: anonymous parameters are deprecated and will be removed in the next edition.
warning: use of deprecated associated function `std::error::Error::description`: use the Display impl or to_string()
warning: use of deprecated associated function `std::error::Error::description`: use the Display impl or to_string()

warning: unused variable
Copy link
Contributor

@mitchmindtree mitchmindtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Just one small change/question then I think this is good to land.

RendererCreationError::PipelineState(ref e) => std::error::Error::description(e),
}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we leave the std::error::Error implementations and only remove the inner description methods instead? Otherwise I think we might break some downstream crates that rely on these error types implementing the std::error::Error trait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants