-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sprint-flying backwards and sidewards #705
base: master
Are you sure you want to change the base?
sprint-flying backwards and sidewards #705
Conversation
"Does" is the wrong word. Please use "fixes", "resolves" or "closes" in the future, these words are tracked by github and make it such that the issue gets automatically closed when the PR is merged. |
src/game.zig
Outdated
} else { | ||
movementSpeed = @max(movementSpeed, 4); | ||
movementDir += right*@as(Vec3d, @splat(-4)); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is a more elegant solution, that doesn't involve copying the same code 4 times, if you use movementSpeed
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, something like what I'm about to commit? It does cause the player to be able to sprint in the directions on ground.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KInd of. But you should readd a special case when on the ground.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did that, that also added diagonal sprinting like in Minecraft.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, I think this diagonal sprinting feels wrong. Can't you just go back to the previous logic when not flying?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tried that and I cant seem to get it to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any progress on this or have you given up?
Try to update your fork @ttmso |
fixes #702