Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sprint-flying backwards and sidewards #705

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ttmso
Copy link
Contributor

@ttmso ttmso commented Sep 9, 2024

fixes #702

@ttmso ttmso marked this pull request as ready for review September 9, 2024 08:37
@IntegratedQuantum
Copy link
Member

IntegratedQuantum commented Sep 9, 2024

"Does" is the wrong word. Please use "fixes", "resolves" or "closes" in the future, these words are tracked by github and make it such that the issue gets automatically closed when the PR is merged.

src/game.zig Outdated
} else {
movementSpeed = @max(movementSpeed, 4);
movementDir += right*@as(Vec3d, @splat(-4));
}
Copy link
Member

@IntegratedQuantum IntegratedQuantum Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a more elegant solution, that doesn't involve copying the same code 4 times, if you use movementSpeed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, something like what I'm about to commit? It does cause the player to be able to sprint in the directions on ground.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KInd of. But you should readd a special case when on the ground.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did that, that also added diagonal sprinting like in Minecraft.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I think this diagonal sprinting feels wrong. Can't you just go back to the previous logic when not flying?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried that and I cant seem to get it to work.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any progress on this or have you given up?

@ikabod-kee
Copy link
Collaborator

I'm unable to compile this due to an incorrect zig download.
image

@ikabod-kee
Copy link
Collaborator

Try to update your fork @ttmso

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sprint-flying backwards and sidewards
3 participants