Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlaidUnicode -> VARCHAR on Databend #100

Merged
merged 1 commit into from
Sep 12, 2024
Merged

PlaidUnicode -> VARCHAR on Databend #100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion plaidcloud/rpc/database.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
from sqlalchemy.dialects.postgresql.json import JSONB
from sqlalchemy.dialects.mssql.base import MSDialect, UNIQUEIDENTIFIER
from sqlalchemy.dialects.mysql.base import MySQLDialect
from sqlalchemy.types import (TypeDecorator, DateTime, Unicode, CHAR, TEXT, NVARCHAR,
from sqlalchemy.types import (TypeDecorator, DateTime, Unicode, CHAR, TEXT, NVARCHAR, VARCHAR,

Check warning on line 25 in plaidcloud/rpc/database.py

View workflow job for this annotation

GitHub Actions / PyLint

[PyLint] plaidcloud/rpc/database.py#L25 

W0611: Unused TEXT imported from sqlalchemy.types (unused-import)
Raw output 
plaidcloud/rpc/database.py:25:0: W0611: Unused TEXT imported from sqlalchemy.types (unused-import)
UnicodeText, NUMERIC, TIMESTAMP, DATETIME, JSON)
from sqlalchemy_hana.dialect import HANAHDBCLIDialect
from sqlalchemy_greenplum.dialect import GreenplumDialect
Expand Down Expand Up @@ -217,6 +217,8 @@
"""
if is_dialect_postgresql_based(dialect):
return dialect.type_descriptor(UnicodeText)
if is_dialect_databend_based(dialect):
return dialect.type_descriptor(VARCHAR)

return self.impl

Expand Down
Loading