Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DB check for dialects that may not be loaded #104

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Fix DB check for dialects that may not be loaded #104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plaidcloud/rpc/database.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,7 +672,7 @@ def is_dialect_greenplum_based(dialect):
>>> is_dialect_greenplum_based(GreenplumDialect())
True
"""
return isinstance(dialect, GreenplumDialect)
return GreenplumDialect is not None and isinstance(dialect, GreenplumDialect)


def is_dialect_hana_based(dialect):
Expand All @@ -692,7 +692,7 @@ def is_dialect_hana_based(dialect):
>>> is_dialect_hana_based(GreenplumDialect())
False
"""
return isinstance(dialect, HANAHDBCLIDialect)
return HANAHDBCLIDialect is not None and isinstance(dialect, HANAHDBCLIDialect)


def is_dialect_mysql_based(dialect):
Expand Down Expand Up @@ -732,7 +732,7 @@ def is_dialect_starrocks_based(dialect):
>>> is_dialect_starrocks_based(GreenplumDialect())
False
"""
return isinstance(dialect, StarRocksDialect)
return StarRocksDialect is not None and isinstance(dialect, StarRocksDialect)


def is_dialect_databend_based(dialect):
Expand All @@ -752,7 +752,7 @@ def is_dialect_databend_based(dialect):
>>> is_dialect_databend_based(GreenplumDialect())
False
"""
return isinstance(dialect, DatabendDialect)
return DatabendDialect is not None and isinstance(dialect, DatabendDialect)


def get_compiled_table_name(engine, schema, table_name):
Expand Down