Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes - use properties, change parent order for Connect #97

Merged
merged 1 commit into from
Sep 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plaidcloud/rpc/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ def _check_environment_variables():
self.workspace_uuid = os.environ['__PLAID_WORKSPACE_UUID__']
self._workflow_id = os.environ['__PLAID_WORKFLOW_ID__']
self._step_id = os.environ['__PLAID_STEP_ID__']
self.verify_ssl = os.environ.get('__PLAID_VERIFY_SSL__', True)
self.verify_ssl = os.environ.get('__PLAID_VERIFY_SSL__', 'True') == 'True'
self.is_local = False
try:
self.hostname = urlparse(self.rpc_uri).netloc
Expand Down
19 changes: 17 additions & 2 deletions plaidcloud/rpc/connection/jsonrpc.py
Original file line number Diff line number Diff line change
Expand Up @@ -176,8 +176,9 @@
def __init__(self, token, uri=None, verify_ssl=None, workspace=None, proxies=None, check_allow_transmit=None,
retry=True, headers=None):
verify_ssl = bool(verify_ssl)
self.rpc_uri = uri
self.verify_ssl = verify_ssl
self.__rpc_uri = uri
self.__verify_ssl = verify_ssl
self.__auth_token = token

def call_rpc(method_path, params, fire_and_forget=False):
if callable(token):
Expand Down Expand Up @@ -215,3 +216,17 @@
)

super(SimpleRPC, self).__init__(call_rpc, check_allow_transmit)

@property
def verify_ssl(self):

Check warning on line 221 in plaidcloud/rpc/connection/jsonrpc.py

View workflow job for this annotation

GitHub Actions / PyLint

[PyLint] plaidcloud/rpc/connection/jsonrpc.py#L221

C0116: Missing function or method docstring (missing-function-docstring)
Raw output
plaidcloud/rpc/connection/jsonrpc.py:221:4: C0116: Missing function or method docstring (missing-function-docstring)
return self.__verify_ssl

@property
def rpc_uri(self):

Check warning on line 225 in plaidcloud/rpc/connection/jsonrpc.py

View workflow job for this annotation

GitHub Actions / PyLint

[PyLint] plaidcloud/rpc/connection/jsonrpc.py#L225

C0116: Missing function or method docstring (missing-function-docstring)
Raw output
plaidcloud/rpc/connection/jsonrpc.py:225:4: C0116: Missing function or method docstring (missing-function-docstring)
return self.__rpc_uri

@property
def auth_token(self):

Check warning on line 229 in plaidcloud/rpc/connection/jsonrpc.py

View workflow job for this annotation

GitHub Actions / PyLint

[PyLint] plaidcloud/rpc/connection/jsonrpc.py#L229

C0116: Missing function or method docstring (missing-function-docstring)
Raw output
plaidcloud/rpc/connection/jsonrpc.py:229:4: C0116: Missing function or method docstring (missing-function-docstring)
if callable(self.__auth_token):
return self.__auth_token()
return self.__auth_token

Check warning on line 232 in plaidcloud/rpc/connection/jsonrpc.py

View workflow job for this annotation

GitHub Actions / PyLint

[PyLint] plaidcloud/rpc/connection/jsonrpc.py#L232

C0304: Final newline missing (missing-final-newline)
Raw output
plaidcloud/rpc/connection/jsonrpc.py:232:0: C0304: Final newline missing (missing-final-newline)
2 changes: 1 addition & 1 deletion plaidcloud/rpc/rpc_connect.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
__license__ = 'Apache 2.0'


class Connect(SimpleRPC, PlaidConfig):
class Connect(PlaidConfig, SimpleRPC):

"""API wrapper class

Expand Down
Loading