Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provision for grouping_sets and rollups #218

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Add provision for grouping_sets and rollups #218

merged 2 commits into from
Nov 22, 2024

Conversation

rad-pat
Copy link
Contributor

@rad-pat rad-pat commented Nov 21, 2024

This is very basic initial implementation, will rollup, cube or create grouping sets on the columns as per group by.

Copy link

github-actions bot commented Nov 21, 2024

File Coverage
All files 39%
plaidcloud/utilities/analyze_table.py 36%
plaidcloud/utilities/bom.py 24%
plaidcloud/utilities/clean_files.py 28%
plaidcloud/utilities/connect.py 35%
plaidcloud/utilities/convert_encoding.py 31%
plaidcloud/utilities/data_helpers.py 26%
plaidcloud/utilities/frame_manager.py 19%
plaidcloud/utilities/pretty_size.py 91%
plaidcloud/utilities/query.py 21%
plaidcloud/utilities/sql_expression.py 85%
plaidcloud/utilities/sqlalchemy_functions.py 63%
plaidcloud/utilities/sqlalchemy_views.py 92%
plaidcloud/utilities/stringtransforms.py 76%
plaidcloud/utilities/udf.py 16%
plaidcloud/utilities/utility.py 19%
plaidcloud/utilities/xray.py 88%
plaidcloud/utilities/remote/dim_helpers.py 10%
plaidcloud/utilities/remote/dimension.py 32%

Minimum allowed coverage is 75%

Generated by 🐒 cobertura-action against 8832ba0

inviscid
inviscid previously approved these changes Nov 21, 2024
@rad-pat
Copy link
Contributor Author

rad-pat commented Nov 22, 2024

Updated to add a fix for Mike running UDFs locally. The auth_token may be a callable method, in which case we should call it.

@rad-pat rad-pat requested review from inviscid and chucklay November 22, 2024 13:52
Copy link
Contributor

@chucklay chucklay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rad-pat rad-pat merged commit 7161254 into master Nov 22, 2024
4 checks passed
@rad-pat rad-pat deleted the sc-18412 branch November 22, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants