Skip to content

Commit

Permalink
Merge pull request #9 from PlanBGmbH/improvements/upgrade
Browse files Browse the repository at this point in the history
Improvements: Switch to Biome, Updated workflow action versions, Angular 19 support
  • Loading branch information
aaronczichon authored Nov 26, 2024
2 parents 8893026 + e542bbd commit a4db798
Show file tree
Hide file tree
Showing 18 changed files with 5,426 additions and 4,117 deletions.
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"vscode": {
"extensions": [
"Angular.ng-template",
"esbenp.prettier-vscode",
"biomejs.biome",
"mutantdino.resourcemonitor",
"GitHub.vscode-github-actions"
]
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/auto-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
label: ${{ steps.get_label.outputs.LABEL }}
pre_release: ${{ steps.prerelease_check.outputs.PRE_RELEASE }}
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Get Version
id: get_version
# E.g. converts ref/tags/v0.0.1 -> 0.0.1
Expand All @@ -37,7 +37,7 @@ jobs:
if: needs.define-variables.outputs.pre_release == 'false'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: 'marvinpinto/action-automatic-releases@latest'
name: Publish Release
with:
Expand All @@ -50,7 +50,7 @@ jobs:
if: needs.define-variables.outputs.pre_release == 'true'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: 'marvinpinto/action-automatic-releases@latest'
name: Publish Release
with:
Expand All @@ -62,10 +62,10 @@ jobs:
needs: [define-variables]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
fetch-depth: 0 # Mandatory to use the extract version from tag action
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: 20
registry-url: https://npm.pkg.github.com/
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Setup Node
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 20
registry-url: https://npm.pkg.github.com/
Expand All @@ -32,7 +32,7 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Changelog Reader
uses: mindsers/[email protected]
Expand Down
1 change: 1 addition & 0 deletions .husky/pre-commit
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
npm run check
1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
20
7 changes: 0 additions & 7 deletions .prettierignore

This file was deleted.

8 changes: 0 additions & 8 deletions .prettierrc

This file was deleted.

3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ We currently support every Angular Version with a minimum requirement of Angular

| Package Version | Supported Angular Version |
| --------------- | ------------------------- |
| 1.x | 17, 18 |
| 1.0.0 | 17, 18 |
| 1.1.0 | 17, 18, 19 |

## Credits

Expand Down
39 changes: 39 additions & 0 deletions biome.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
{
"$schema": "https://biomejs.dev/schemas/1.9.4/schema.json",
"vcs": { "enabled": false, "clientKind": "git", "useIgnoreFile": false },
"files": { "ignoreUnknown": false, "ignore": [] },
"formatter": {
"enabled": true,
"useEditorconfig": true,
"formatWithErrors": false,
"indentStyle": "tab",
"indentWidth": 2,
"lineEnding": "lf",
"lineWidth": 100,
"attributePosition": "auto",
"bracketSpacing": true,
"ignore": [
"dist/**",
"src/assets/*",
"documentation/**",
"**/build.ts",
"**/tmp/",
".angular/**"
]
},
"organizeImports": { "enabled": true },
"linter": { "enabled": true, "rules": { "recommended": true } },
"javascript": {
"formatter": {
"jsxQuoteStyle": "double",
"quoteProperties": "asNeeded",
"trailingCommas": "all",
"semicolons": "always",
"arrowParentheses": "always",
"bracketSameLine": false,
"quoteStyle": "single",
"attributePosition": "auto",
"bracketSpacing": true
}
}
}
Loading

0 comments on commit a4db798

Please sign in to comment.