Fix for OpenCL 2.0 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PlasmaPower
approved these changes
Jun 29, 2021
|
|
||
| static int blake2b_final( blake2b_state *S, uchar *out, uchar outlen ) | ||
| /* Is this correct? */ | ||
| static int blake2b_final( __private blake2b_state *S, uchar *out, uchar outlen ) |
There was a problem hiding this comment.
What's this comment about? AFAIK it's correct.
There was a problem hiding this comment.
Oops, sorry about that, the comment was copy-pasted from Nano, removed
Just got a friend to test - works on OpenCL 1.2 - GeForce GTX 1070 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default address space changed from private to generic in OpenCL 2.0, causing #40. This merges some OpenCL optimizations from Nano, and fixes the issue.