-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix migrate taxref command for false merge conflitcs #528
base: develop
Are you sure you want to change the base?
Conversation
"action" = 'Conflicts with attributes : ' || atts | ||
FROM conflict_atts_text AS a | ||
WHERE a.f_cd_ref = c.f_cd_ref | ||
AND cas = 'merge' ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Est ce qu'il ne faudrait pas ajouter AND "action" IS NULL
ici ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finalement, après relecture du code SQL, je dirai que non car le champ "action" est potentielle déjà rempli. Par exemple avec 'Update cd_ref no changes for attributes and medium'.
Salut @jpm-cbna, La procédure de migration a subi des changements notoires dans la V2 de TaxHub, plus précisément à cause de la suppression de la table |
1d19638
to
7304d09
Compare
Oui, j'en ai bien conscience. C'est juste que j'avais besoin de comprendre d'où venaient les problèmes pour les corriger. Au final les corrections présentes dans le commit 7304d09 sont très simples et m'ont permis de réaliser proprement la migration. |
See: #527
Two commites first 14532af with SQL refactoring, second 7304d09 with fixes.