Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(taxref): add taxref_tree materialized view #567

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

bouttier
Copy link
Contributor

@bouttier bouttier commented Oct 8, 2024

Pour chaque cd_nom, la VM contient la liste des cd_ref parents jusqu’a Biota (cd_nom 349525)

Voir #354

@bouttier bouttier force-pushed the feat/taxref-tree branch 3 times, most recently from f89e600 to e84cb84 Compare October 8, 2024 14:42
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.20%. Comparing base (06c0dcc) to head (ac34c57).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
apptax/taxonomie/commands/utils.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #567      +/-   ##
===========================================
+ Coverage    51.98%   52.20%   +0.21%     
===========================================
  Files           37       37              
  Lines         2418     2431      +13     
===========================================
+ Hits          1257     1269      +12     
- Misses        1161     1162       +1     
Flag Coverage Δ
pytest 52.20% <92.85%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bouttier bouttier force-pushed the feat/taxref-tree branch 2 times, most recently from bc33d0c to 242e678 Compare October 10, 2024 12:58
@bouttier bouttier changed the title draft: feat(taxref): add cd_ref path (ltree) mat. view feat(taxref): add taxref_tree materialized view Oct 10, 2024
@bouttier
Copy link
Contributor Author

PR ok pour merge

Copy link
Contributor

@jacquesfize jacquesfize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testé, tout est bon de mon côté ! Juste côté changelog, autant mettre ça dans la 2.0.0 ?

@bouttier
Copy link
Contributor Author

Ah oui je sais pas pourquoi j’ai cru que la 2.0 était déjà sortie, je change ça

@camillemonchicourt
Copy link
Member

Je pense que pour les installations classiques de TH ou GN, l'ajout de l'extension ne passera pas dans la migration, mais qu'il faudra l'installer manuellement avec une commande comme dans la 1.8.0 : https://github.com/PnX-SI/TaxHub/blob/develop/docs/changelog.md#180-2021-06-22

Mais aussi le préciser côté Changelog de GN, car c'est surtout là que les administrateurs auront à le faire.

@bouttier bouttier added this to the V2 milestone Oct 22, 2024
@jacquesfize jacquesfize merged commit 8cd6d28 into develop Oct 24, 2024
6 checks passed
@camillemonchicourt camillemonchicourt deleted the feat/taxref-tree branch October 29, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants