fix(marticle): updates a use case where ul nodes could contain spans and be within a div #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bassrock
commented
Nov 7, 2024
servers/parser-graphql-wrapper/src/marticle/marticleParser.spec.ts
Outdated
Show resolved
Hide resolved
bassrock
commented
Nov 7, 2024
bassrock
commented
Nov 7, 2024
bassrock
force-pushed
the
fix/undefined-children
branch
from
000cc4d
to
efb6c51
Compare
bassrock
changed the title
bassrock
requested review from
marcin-kozinski
and removed request for
a team
bassrock
force-pushed
the
fix/undefined-children
branch
from
fa7aaae
to
7a6f42a
Compare
bassrock
force-pushed
the
fix/undefined-children
branch
from
7a6f42a
to
211ea9a
Compare
Gio2018
approved these changes
Nov 13, 2024
kschelonka
reviewed
Nov 13, 2024
| level: 0, | ||
| content: '1-2.', | ||
| }, | ||
| { |
There was a problem hiding this comment.
The schema doesn't allow returning unmarseable in lists so we'll have to update the caller function to remove this or pop it out
bassrock
force-pushed
the
fix/undefined-children
branch
from
fc1e289
to
a42d78f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fix a long time sentry undefined issue https://pocket.sentry.io/issues/4818338635/?project=5591912&query=is%3Aunresolved%20issue.priority%3A%5Bhigh%2C%20medium%5D&referrer=issue-stream&sort=date&statsPeriod=14d&stream_index=4