-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tax free childcare #1004
base: master
Are you sure you want to change the base?
Tax free childcare #1004
Conversation
@PavelMakarchuk could you please meet with @vahid-ahmadi on this? Probably easier than text review for getting the parameters and vectorization in for the first time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Come initial comments but will meet to discuss in detail
basic_age_condition = (age < 12) | ||
age_under_17 = (age < 17) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to parameterize values such as "12" and "17" - in general we try to avoid hard coding any values that could be adjusted through a parameter reform.
# Combine conditions | ||
eligible = basic_age_condition | (age_under_17 & is_disabled) | ||
|
||
return benunit.any(eligible) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this is a person level variable we do not need to add the benunit.any
condition
we want to return basic_age_condition | (age_under_17 & is_disabled)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a class
Use underscores when naming files instead of "-"
|
||
class childcare_work_condition(Variable): | ||
value_type = bool | ||
entity = Person |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar question for each of the files - do we want to compute this for each person or for the entire Benefit Unit?
Overview
This PR implements the Tax-Free Childcare (TFC) scheme calculation in PolicyEngine UK. The scheme provides government contributions towards childcare costs for eligible families. (Documentation link)
Key Features
Fixes #1002