Alabama federal income tax deduction #3264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
policyengine_us/variables/gov/states/al/tax/income/deductions/al_federal_tax_deduction.py
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3264 +/- ##
=======================================
Coverage 99.05% 99.05%
=======================================
Files 1887 1887
Lines 27687 27689 +2
Branches 162 162
=======================================
+ Hits 27426 27428 +2
Misses 224 224
Partials 37 37 ☔ View full report in Codecov by Sentry. |
...e_us/tests/policy/baseline/gov/states/al/tax/income/deductions/al_federal_tax_deduction.yaml
Outdated
Show resolved
Hide resolved
PavelMakarchuk
approved these changes
Nov 16, 2023
MaxGhenis
requested changes
Nov 17, 2023
policyengine_us/variables/gov/states/al/tax/income/deductions/al_federal_tax_deduction.py
Outdated
Show resolved
Hide resolved
MaxGhenis
requested changes
Nov 22, 2023
MaxGhenis
requested changes
Nov 26, 2023
...yengine_us/parameters/gov/states/al/tax/income/deductions/federal_tax/countable_sources.yaml
Outdated
Show resolved
Hide resolved
...yengine_us/parameters/gov/states/al/tax/income/deductions/federal_tax/countable_sources.yaml
Show resolved
Hide resolved
MaxGhenis
reviewed
Nov 26, 2023
policyengine_us/variables/gov/states/al/tax/income/deductions/al_deductions.py
Outdated
Show resolved
Hide resolved
Addressed the Comments
MaxGhenis
reviewed
Nov 29, 2023
...cyengine_us/variables/gov/states/al/tax/income/deductions/al_federal_income_tax_deduction.py
Outdated
Show resolved
Hide resolved
MaxGhenis
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3252
🤖 Generated by Copilot at 42776f7
Summary
📝🧪🚀
This pull request adds a new feature to the policy engine: the Alabama federal income tax deduction. It updates the changelog, implements the formula for the deduction variable, and adds unit tests for the feature.
Walkthrough
al_federal_tax_deductionvariable as the difference between federal income tax and Alabama tax credits, with a lower bound of zero (link)al_federal_tax_deductionvariable inpolicyengine_us/tests/policy/baseline/gov/states/al/tax/income/deductions/al_federal_tax_deduction.yaml, covering different scenarios of income tax, net investment income tax, and federal tax credits (link)