Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter 7 bankruptcy means test #5323

Draft
wants to merge 45 commits into
base: master
Choose a base branch
from

Conversation

hua7450
Copy link
Collaborator

@hua7450 hua7450 commented Nov 12, 2024

Fixes #5109

Copy link
Collaborator

@PavelMakarchuk PavelMakarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts, can ignore if in the process

Copy link
Collaborator

@PavelMakarchuk PavelMakarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial format

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.11%. Comparing base (75cc11e) to head (2a2c1e7).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #5323    +/-   ##
========================================
  Coverage   99.10%   99.11%            
========================================
  Files        2687     2710    +23     
  Lines       38934    39292   +358     
  Branches      170      170            
========================================
+ Hits        38585    38943   +358     
  Misses        315      315            
  Partials       34       34            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hua7450 hua7450 requested a review from PavelMakarchuk January 7, 2025 02:19
Copy link
Collaborator

@PavelMakarchuk PavelMakarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add one integration test following the formula from the form:
https://www.cacb.uscourts.gov/sites/cacb/files/documents/forms/122A2.pdf#page=6

Copy link
Collaborator

@daphnehanse11 daphnehanse11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only question is about the position of the metadata in the file I commented on, not sure if that is formatted correctly

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe specify for each person over 4?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we accounting for this "* Subject to adjustment on 4/01/25, and every 3 years after that for cases filed on or after the date of adjustment."

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the year to 2022; we can add the 2025's values once it's been released.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the metadata supposed to be at the bottom of the file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bottom or top, either way works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chapter 7 bankruptcy means test
4 participants