-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✅ New e2e tests #405
Open
JuaniRios
wants to merge
1
commit into
09-27-test_usdt_transaction_payment
Choose a base branch
from
09-25-new_e2e_tests
base: 09-27-test_usdt_transaction_payment
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
✅ New e2e tests #405
+801
−435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 30, 2024
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @JuaniRios and the rest of your teammates on Graphite |
JuaniRios
force-pushed
the
09-19-otm_funding_tests
branch
from
September 30, 2024 13:00
228d298
to
ac29096
Compare
JuaniRios
force-pushed
the
09-25-new_e2e_tests
branch
from
September 30, 2024 13:00
6b28e5e
to
d5bf333
Compare
JuaniRios
force-pushed
the
09-19-otm_funding_tests
branch
3 times, most recently
from
September 30, 2024 13:14
5115a7b
to
990eb8b
Compare
JuaniRios
force-pushed
the
09-25-new_e2e_tests
branch
from
October 1, 2024 09:20
d5bf333
to
af03235
Compare
JuaniRios
changed the base branch from
09-19-otm_funding_tests
to
09-27-test_usdt_transaction_payment
October 1, 2024 09:20
JuaniRios
force-pushed
the
09-25-new_e2e_tests
branch
6 times, most recently
from
October 3, 2024 13:03
af14208
to
5bc4c91
Compare
JuaniRios
force-pushed
the
09-25-new_e2e_tests
branch
from
October 3, 2024 13:35
5bc4c91
to
17b0ea7
Compare
JuaniRios
force-pushed
the
09-27-test_usdt_transaction_payment
branch
from
October 3, 2024 13:49
4c8d6cf
to
f00ff56
Compare
JuaniRios
force-pushed
the
09-25-new_e2e_tests
branch
from
October 3, 2024 13:49
17b0ea7
to
da0f00d
Compare
JuaniRios
force-pushed
the
09-27-test_usdt_transaction_payment
branch
from
October 3, 2024 14:51
f00ff56
to
618f4e5
Compare
JuaniRios
force-pushed
the
09-25-new_e2e_tests
branch
2 times, most recently
from
October 4, 2024 09:43
d1bf42e
to
d099958
Compare
JuaniRios
force-pushed
the
09-27-test_usdt_transaction_payment
branch
from
October 4, 2024 10:32
618f4e5
to
6c1ad29
Compare
JuaniRios
force-pushed
the
09-25-new_e2e_tests
branch
from
October 4, 2024 10:32
d099958
to
8b19fd8
Compare
JuaniRios
force-pushed
the
09-27-test_usdt_transaction_payment
branch
from
October 4, 2024 12:17
6c1ad29
to
9331229
Compare
JuaniRios
force-pushed
the
09-25-new_e2e_tests
branch
from
October 4, 2024 12:17
8b19fd8
to
a9bd91b
Compare
JuaniRios
force-pushed
the
09-27-test_usdt_transaction_payment
branch
from
October 7, 2024 13:02
9331229
to
6da7c33
Compare
JuaniRios
force-pushed
the
09-25-new_e2e_tests
branch
from
October 7, 2024 13:02
a9bd91b
to
474234a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add new e2e tests
Why?
OTM Flow and simplifications were added, so we needed to recheck all the numbers.
How?
Delete everything and start over with this spreadsheet:
https://docs.google.com/spreadsheets/d/1BiKZCf50S9U_jiPPShTqmL6A_DUlFqwx/edit?gid=114355434#gid=114355434
Testing?
Only one test in the e2e.rs file that goes over everything.
Anything Else?
I added a bacon.toml config file. bacon is the successor to cargo watch. Its a program you leave running in the background and dynamically shows you errors from the compiler instead of having to constantly call cargo check or cargo test.
Kind of what rust-analyzer does, but I usually have it disabled because it makes everything mega slow.