Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6.0.1 #932

Merged
merged 33 commits into from
Mar 27, 2024
Merged

v6.0.1 #932

merged 33 commits into from
Mar 27, 2024

Conversation

Gauthamastro
Copy link
Member

@Gauthamastro Gauthamastro commented Mar 20, 2024

Describe your changes

  1. Add Saturating sub for close auction calculations
  2. Add more events in Thea executor
  3. Fixed fetch_checkpoint API
  4. Removed typos

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • I removed all Clippy and Formatting Warnings.
  • I added required Copyrights.

Gauthamastro and others added 7 commits March 19, 2024 09:38
## Describe your changes

1. The auction logic is now using saturating subtraction.
2. Fixed a typo
)

## Describe your changes
Added more events to help frontend team to track withdrawal status.
@Gauthamastro Gauthamastro added the A0-PleaseReview Pull request needs code review. label Mar 20, 2024
Copy link
Contributor

coderabbitai bot commented Mar 20, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 20.77922% with 122 lines in your changes are missing coverage. Please review.

Project coverage is 40.77%. Comparing base (db7ae33) to head (3d7ed6e).
Report is 3 commits behind head on mainnet-release.

Files Patch % Lines
pallets/ocex/src/lib.rs 6.00% 47 Missing ⚠️
pallets/ocex/src/validator.rs 0.00% 23 Missing ⚠️
pallets/ocex/src/lmp.rs 53.65% 19 Missing ⚠️
pallets/thea-executor/src/lib.rs 8.33% 11 Missing ⚠️
primitives/orderbook/src/lib.rs 0.00% 6 Missing ⚠️
primitives/orderbook/src/recovery.rs 0.00% 6 Missing ⚠️
pallets/thea-message-handler/src/lib.rs 0.00% 3 Missing ⚠️
pallets/thea/src/lib.rs 0.00% 3 Missing ⚠️
pallets/ocex/rpc/src/lib.rs 0.00% 2 Missing ⚠️
pallets/ocex/src/settlement.rs 75.00% 2 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           mainnet-release     #932      +/-   ##
===================================================
- Coverage            41.26%   40.77%   -0.50%     
===================================================
  Files                   67       67              
  Lines                 5462     5553      +91     
===================================================
+ Hits                  2254     2264      +10     
- Misses                3208     3289      +81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Gauthamastro and others added 16 commits March 20, 2024 11:47
## Describe your changes
Adds LMP storage states to ObCheckpoint.

## Checklist before requesting a review
- [x] I have performed a self-review of my code.
- [ ] If it is a core feature, I have added thorough tests.
- [x] I removed all Clippy and Formatting Warnings. 
- [x] I added required Copyrights.
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Updated origin verification to utilize
`T::GovernanceOrigin::ensure_origin` for enhanced control flow and
security.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Describe your changes

The validator is rejecting withdrawals even if the deviation is below
system min limit but such a withdrawal should be allowed with balance in
offchain state.

## Checklist before requesting a review
- [ ] I have performed a self-review of my code.
- [ ] If it is a core feature, I have added thorough tests.
- [ ] I removed all Clippy and Formatting Warnings. 
- [ ] I added required Copyrights.
## Describe your changes

Wrap around q score sample index if it overflows
## Describe your changes

Increase ED for AutoSwap to 1.5 PDEX
@Gauthamastro Gauthamastro merged commit 0ba43f1 into mainnet-release Mar 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-PleaseReview Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants