fix: change check to governance

[nuel77]

Summary by CodeRabbit

• Refactor
  • Updated origin verification to utilize T::GovernanceOrigin::ensure_origin for enhanced control flow and security.

[coderabbitai]

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Walkthrough

The modification shifts the method of origin verification in a specific function. Instead of using a direct root check (ensure_root), it now employs a more flexible approach by utilizing T::GovernanceOrigin::ensure_origin. This change potentially broadens the range of entities that can trigger the function, aligning with a governance model rather than a single root authority.

Changes

Files	Change Summary
.../thea-executor/src/lib.rs	Replaced ensure_root with T::GovernanceOrigin::ensure_origin in origin verification

🐇✨
In the realm of code, where logic threads weave,
A change was made, in the way we perceive.
No longer just root, but governance's grace,
A broader embrace, in the verification space.
Hoppity hop, on the blockchain we race,
With every commit, a better place we chase.
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[nuel77]

@coderabbitai review

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between f70e573 and faafa3a.

Files selected for processing (1)

• pallets/thea-executor/src/lib.rs (1 hunks)

Additional comments: 2

pallets/thea-executor/src/lib.rs (2)

• 356-356: The change from ensure_root to T::GovernanceOrigin::ensure_origin in the update_asset_metadata function aligns with the PR's objective to shift from a root-based permission check to a governance-based permission model. This is a significant change in how permissions are managed for this operation, potentially allowing for more democratic or decentralized control over these critical operations.

Ensure that the governance model configured for T::GovernanceOrigin is thoroughly tested to prevent unauthorized access or actions that could compromise the system's integrity. Additionally, consider documenting the expected governance model or requirements in the code or project documentation to clarify the intended use and restrictions of these functions.

• 356-356: The change to use T::GovernanceOrigin::ensure_origin for the burn_native_tokens function is consistent with the shift towards governance-based permission checks. This adjustment ensures that the action of burning native tokens, which can have significant implications for the token economy and user balances, is subject to governance oversight rather than being solely under root control.

As with the update_asset_metadata function, it's crucial to ensure that the governance mechanisms in place are robust and secure. Testing and documentation around these governance processes will help maintain system integrity and provide clarity to future developers and auditors.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.17%. Comparing base (f70e573) to head (955d78d).

Additional details and impacted files

@@           Coverage Diff            @@
##           Develop     #933   +/-   ##
========================================
  Coverage    41.17%   41.17%           
========================================
  Files           67       67           
  Lines         5474     5474           
========================================
  Hits          2254     2254           
  Misses        3220     3220           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.