Feat/rt cetsa #541
Open
Feat/rt cetsa #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: containerized plate extraction and run with cwl.
…original intensities.
agerardin
requested review from
Nicholas-Schaub,
NHotaling and
hsidky
as code owners
nishaq503
requested changes
Jun 3, 2024
Comment on lines
+23
to
+25
| | `--preview` | Generate JSON file with outputs | Output | JSON | Optional | ||
| | `--params` | Plate params to use | Output | JSON | Optional | ||
| | `--temp` | Temperature range. Default to [37,90] | Output | JSON | Optional |
There was a problem hiding this comment.
These three lines need an additional column in the table.
Comment on lines
+37
to
+48
| { | ||
| "name": "params", | ||
| "type": "boolean", | ||
| "description": "Plate params to use.", | ||
| "required": false | ||
| }, | ||
| { | ||
| "name": "temp", | ||
| "type": "boolean", | ||
| "description": "Temperature range. Default to [37,90].", | ||
| "required": false | ||
| } |
There was a problem hiding this comment.
The types for these are listed as JSON in the README, string in the ICT and boolean here. What is the actual type?
| bfio = "^2.3.6" | ||
| scikit-image = "^0.22.0" | ||
| imagecodecs = "^2024.1.1" | ||
| polus-images-segmentation-rt-cetsa-plate-extraction = {git = "https://github.com/agerardin/image-tools.git", branch = "feat/rt_cetsa", subdirectory = "segmentation/rt-cetsa-plate-extraction-tool"} |
There was a problem hiding this comment.
This git link will need to be updated to either use the main repo from polusai and the master branch, or it should be changed to a local path dependency
| | `--inpDir` | Input data collection to be processed by this tool | Input | genericData | | ||
| | `--filePattern` | FilePattern to parse input files | Input | string | | ||
| | `--outDir` | Output dir | Output | genericData | | ||
| | `--preview` | Generate JSON file with outputs | Output | JSON | Optional |
There was a problem hiding this comment.
This line needs another column
Comment on lines
+214
to
+215
| This method is degree of magnitude slower than extract_wells_intensity | ||
| and is just provided for convenience. Consider using extract_wells_intensity instead. |
There was a problem hiding this comment.
I am surprised that numpy indexing with a mask is so much slower. I'll have to keep that in mind if we can assume that masks always have a specific shape
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two new tools :