Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #139: Use SVG to draw the checkmark. #142

Closed
wants to merge 6 commits into from
Closed

Conversation

bicknellr
Copy link
Contributor

@bicknellr bicknellr commented Jul 21, 2016

Go to either demo below and resize the window to see the difference:

before: http://jsbin.com/fepide/1/edit?html,output
screen shot 2016-07-20 at 17 46 17

after: http://jsbin.com/lisubu/1/edit?html,output
screen shot 2016-07-20 at 17 46 24

(Fixes #139.)

@abdonrd
Copy link
Member

abdonrd commented Jul 21, 2016

Why not use the icon-icons "check" icon?

@bicknellr
Copy link
Contributor Author

@abdonrd good idea! I rather not make paper-checkbox depend on iron-icon but it's definitely a better source for the SVG than trying to roll my own.

@abdonrd
Copy link
Member

abdonrd commented Jul 21, 2016

@bicknellr why not use the iron-icon element?

@bicknellr bicknellr mentioned this pull request Aug 9, 2016
@bicknellr
Copy link
Contributor Author

@rictic

@bicknellr
Copy link
Contributor Author

@cdata is it ok if I assign this to you?

@bicknellr bicknellr assigned bicknellr and cdata and unassigned bicknellr Sep 8, 2016
@danbeam
Copy link
Contributor

danbeam commented Dec 9, 2016

yo, what's the status on this?

@dima-gorskov
Copy link

When merge this PR?

@e111077
Copy link
Contributor

e111077 commented Jun 6, 2017

This visual change will cause quite a bit of jank between the old and new versions which would break a lot of visual tests.

2017-06-05 17_15_17

I'm for SVGification, but on the fence about the recentering (as it's non-standard as is).

Thoughts @notwaldorf @rictic?

@e111077
Copy link
Contributor

e111077 commented Jan 31, 2018

Would like to know how this PR fares in our internal tests.

@notwaldorf
Copy link
Contributor

notwaldorf commented Mar 7, 2018

(going to remove myself as a reviewer since I think Elliott has this covered!)

@notwaldorf notwaldorf removed their request for review March 7, 2018 01:10
@e111077
Copy link
Contributor

e111077 commented Mar 7, 2018

@bicknellr any updates on internal testing?

@bicknellr
Copy link
Contributor Author

Last I checked, it breaks a bunch of screenshot tests - as expected. I don't remember there being any obviously broken non-screenshot tests but I should run it again.

Copy link
Contributor

@e111077 e111077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for update / resolution on this

@bicknellr bicknellr closed this Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants