Frame v2 upgrade part7 #1779
Open
Frame v2 upgrade part7 #1779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neopallium
force-pushed
the
frame_v2_upgrade_part6
branch
from
684fb60 to
0a8c08d
Compare
Neopallium
force-pushed
the
frame_v2_upgrade_part7
branch
from
63de7e8 to
8f8a265
Compare
Neopallium
force-pushed
the
frame_v2_upgrade_part6
branch
from
0a8c08d to
7cb5dff
Compare
Neopallium
force-pushed
the
frame_v2_upgrade_part7
branch
2 times, most recently
from
3e86c04 to
51b6934
Compare
Neopallium
commented
Dec 31, 2024
Comment on lines
811
to
-676
| _auth_issuer_pays: bool, | ||
| ) { |
There was a problem hiding this comment.
The API check fails do to the parameter _auth_issuer_pays being renamed to auth_issuer_pays. It seems the new FRAME v2 codegen drops the _ prefix.
Neopallium
force-pushed
the
frame_v2_upgrade_part7
branch
from
2159acc to
51b6934
Compare
Neopallium
force-pushed
the
frame_v2_upgrade_part6
branch
from
7cb5dff to
840e959
Compare
Neopallium
force-pushed
the
frame_v2_upgrade_part7
branch
from
51b6934 to
cb7fbe8
Compare
Neopallium
force-pushed
the
frame_v2_upgrade_part6
branch
from
840e959 to
9c4314b
Compare
Neopallium
force-pushed
the
frame_v2_upgrade_part7
branch
from
cb7fbe8 to
5bdd573
Compare
Neopallium
force-pushed
the
frame_v2_upgrade_part6
branch
from
9c4314b to
019b494
Compare
Neopallium
force-pushed
the
frame_v2_upgrade_part7
branch
from
5bdd573 to
7018f65
Compare
Neopallium
force-pushed
the
frame_v2_upgrade_part6
branch
from
019b494 to
59e661c
Compare
Neopallium
force-pushed
the
frame_v2_upgrade_part7
branch
from
7018f65 to
316fceb
Compare
Neopallium
force-pushed
the
frame_v2_upgrade_part6
branch
from
59e661c to
7026d90
Compare
Neopallium
force-pushed
the
frame_v2_upgrade_part7
branch
from
316fceb to
a2c8e0f
Compare
Update Portfolio pallet. Update Settlement pallet. Update Identity pallet.
Neopallium
force-pushed
the
frame_v2_upgrade_part6
branch
from
7026d90 to
28457ad
Compare
Neopallium
force-pushed
the
frame_v2_upgrade_part7
branch
from
a2c8e0f to
90f202f
Compare
HenriqueNogara
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.