Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WalletConnect signing manager #50

Merged
merged 1 commit into from
May 30, 2024
Merged

Add WalletConnect signing manager #50

merged 1 commit into from
May 30, 2024

Conversation

F-OBrien
Copy link
Contributor

Description

Adds a new signing manager that allows remote wallets to connect to the Polymesh SDK using WalletConnect.

Breaking Changes

NA

JIRA Link

NA

Checklist

  • Updated the Readme.md (if required) ?

Copy link
Collaborator

@polymath-eric polymath-eric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm. I left some nitty comment + there are sonar cloud warnings that should be taken care off.

Copy link
Collaborator

@polymath-eric polymath-eric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you are actually deregistering the listeners on disconnect based on JS always comparing with referential equality. I missed that on the first review.

Also some nits around as any warnings.

Other than that LGTM

Copy link
Collaborator

@polymath-eric polymath-eric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I left one optional comment

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@F-OBrien F-OBrien merged commit c240c88 into main May 30, 2024
4 checks passed
@F-OBrien F-OBrien deleted the walletconnect branch May 30, 2024 15:19
@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version @polymeshassociation/[email protected] 🎉

The release is available on:

@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version 3.4.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants