Updated the "Hidden Input Field Detection at Response Level (Passive)" Finding #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated regex to look for type="hidden" in an input field wherever it is in that hidden HTML element. - Included detection for style="display: none;" - Updated descriptions for detail & remediation.
Hannah-PortSwigger
requested changes
Oct 3, 2024
|
|
||
| define: | ||
|
|
||
| # Issue Details: |
There was a problem hiding this comment.
Splitting the issue details and remediation advice into small chunks makes this code difficult to read. Can you please inline these into the report issue: block.
| define: | ||
|
|
||
| # Issue Details: | ||
| id_01 = `- An '<input>' HTML field with the 'type="hidden"' or 'style="display: none;"' attribute has been detected.\n - This HTML field may be suseptible to XSS injections.` |
There was a problem hiding this comment.
Small typo: susceptible
| ir_06 = `\n > Libraries like 'DOMPurify', 'Helmet', & 'ESAPI' exist to automate detection of illicit characters & character types.` | ||
| ir_07 = `\n\n3. RESPONSE: If unapproved characters become detected, either 'REJECT this payload' immediately OR 'SANITIZE & REEVALUATE this payload'.` | ||
| ir_08 = `\n > REJECT: Deny data transferal from this payload & send a response which indicates that rejection has occurred.` | ||
| ir_09 = `\n > SANITIZE & REEVALUATE: Perform sanatization on non-whitelisted characters once to convert these values into safer alternatives.` |
There was a problem hiding this comment.
Small typo: sanitization
| ir_09a = ` Then reevaluate the payload for illicit characters again & REJECT this time if unsafe.` | ||
| ir_10 = `\n >> This practice should be tried if 'necessary' content appears expected to possess known-illicit characters (& this functionality cannot be rewritten).` | ||
| ir_11 = `\n\n4. ENCODE: If approved, this application must encode all HTML metacharacters contained within user input whenever this content would be copied directly into an HTTP webpage.` | ||
| ir_12 = `\n > For example: '<' becomes '<', '>' becomes '>', '&' becomes '&', '"' becomes '"', & etcetera.` |
There was a problem hiding this comment.
Small typo: No need for the "& etcetera." - this can just be "etc." or "et cetera."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
<input>hastype="hidden"as its very first attribute.style="display: none;"Ask: As this is a significant update to a pre-existing bcheck file, please let me know what the correct syntax is for multiple authors.
BCheck Contributions