Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PostHogOptions and FeatureFlagOptions into PostHog namespace #51

Merged
merged 6 commits into from
Feb 14, 2025

Conversation

haacked
Copy link
Collaborator

@haacked haacked commented Feb 14, 2025

No need to import another namespace for a common scenario.

No need to import another namespace for a common scenario.
These are the code examples I use on posthog.com.
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR simplifies the namespace structure by moving PostHogOptions and FeatureFlagOptions into the root PostHog namespace, reducing import complexity across the codebase.

  • Version bumped to 1.0.0-beta.8 in Directory.Build.props to reflect breaking namespace changes
  • Redundant Nullable property defined twice in Directory.Build.props should be cleaned up
  • Copyright year incorrectly set to 2025 in Directory.Build.props needs updating
  • New Examples.cs file has potential issues with static PostHogClient instance and resource disposal
  • Examples.cs contains redundant feature flag pattern demonstrations that should be consolidated

16 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile

@haacked haacked merged commit a6239f2 into main Feb 14, 2025
4 checks passed
@haacked haacked deleted the haacked/more-refactorings branch February 14, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant