Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Surveys): Enable partial survey responses #1597

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Phanatic
Copy link
Contributor

Changes

This PR enables the SDK to send partial survey responses as users fill out the survey, not at the end once all questions are answered : PostHog/posthog#19300
We introduced a new config option called disable_survey_partial_response which is true by default. Customers have to set this to false to get the feature enabled

Not supported

  • Continuing filling out a survey after a browser session refresh. We will send question responses as they are answered, and don't allow you to fill out a few questions, come back later, and then fill them out.

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

@Phanatic Phanatic requested a review from marandaneto December 11, 2024 15:28
Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ❌ Failed (Inspect) Dec 20, 2024 5:16pm

src/posthog-core.ts Outdated Show resolved Hide resolved
@marandaneto marandaneto requested a review from ioannisj December 12, 2024 10:05
@posthog-bot
Copy link
Collaborator

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

Co-authored-by: Manoel Aranda Neto <[email protected]>
Copy link

@ioannisj ioannisj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine this needs changes BE side as well to handle survey_response_id payload? Also, CI is failing, no idea how to address this

@posthog-bot
Copy link
Collaborator

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants