Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patch how rrweb loads iframe #1660

Closed
wants to merge 1 commit into from

Conversation

pauldambra
Copy link
Member

@pauldambra pauldambra commented Jan 19, 2025

patches rrweb-io/rrweb#1633 into our copy of the recorder

moves the iframe from the body to the head
and marks it as hidden
both changes are intended to make this more consistent in safari, since we see it fail particularly in angular apps running in safari

Copy link

vercel bot commented Jan 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Jan 19, 2025 10:36am

Copy link

Size Change: -408 B (-0.01%)

Total Size: 3.25 MB

Filename Size Change
dist/all-external-dependencies.js 208 kB -58 B (-0.03%)
dist/array.full.js 369 kB -58 B (-0.02%)
dist/array.full.no-external.js 367 kB -58 B (-0.02%)
dist/module.full.js 369 kB -58 B (-0.02%)
dist/module.full.no-external.js 367 kB -58 B (-0.02%)
dist/recorder-v2.js 116 kB -59 B (-0.05%)
dist/recorder.js 116 kB -59 B (-0.05%)
ℹ️ View Unchanged
Filename Size
dist/array.full.es5.js 265 kB
dist/array.js 181 kB
dist/array.no-external.js 180 kB
dist/customizations.full.js 13.8 kB
dist/dead-clicks-autocapture.js 14.4 kB
dist/exception-autocapture.js 9.48 kB
dist/external-scripts-loader.js 2.64 kB
dist/main.js 182 kB
dist/module.js 181 kB
dist/module.no-external.js 180 kB
dist/surveys-preview.js 58.1 kB
dist/surveys.js 63.8 kB
dist/tracing-headers.js 1.76 kB
dist/web-vitals.js 10.4 kB

compressed-size-action

@pauldambra
Copy link
Member Author

it's definitely not this

@pauldambra pauldambra closed this Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant