Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expose getNextSurveyStep to use in posthog #1661

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

lucasheriques
Copy link
Contributor

Changes

No functional changes.

Exposes getNextSurveyStep to the exported functions so we don't need to duplicate that logic on posthog/posthog for survey previewing purposes

Checklist

  • Tests for new code (no code changes, just exposing a function)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

@lucasheriques lucasheriques added the bump patch Bump patch version when this PR gets merged label Jan 20, 2025
@lucasheriques lucasheriques requested a review from a team January 20, 2025 19:24
Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Jan 20, 2025 7:27pm

Copy link

Size Change: +9.2 kB (+0.28%)

Total Size: 3.26 MB

Filename Size Change
dist/array.full.es5.js 265 kB +1 B (0%)
dist/array.full.js 369 kB +25 B (+0.01%)
dist/array.full.no-external.js 367 kB +25 B (+0.01%)
dist/array.js 181 kB +28 B (+0.02%)
dist/array.no-external.js 180 kB +28 B (+0.02%)
dist/main.js 182 kB +29 B (+0.02%)
dist/module.full.js 369 kB +25 B (+0.01%)
dist/module.full.no-external.js 367 kB +25 B (+0.01%)
dist/module.js 181 kB +28 B (+0.02%)
dist/module.no-external.js 180 kB +28 B (+0.02%)
dist/surveys-preview.js 67.1 kB +8.96 kB (+15.41%) ⚠️
ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 208 kB
dist/customizations.full.js 13.8 kB
dist/dead-clicks-autocapture.js 14.4 kB
dist/exception-autocapture.js 9.48 kB
dist/external-scripts-loader.js 2.64 kB
dist/recorder-v2.js 116 kB
dist/recorder.js 116 kB
dist/surveys.js 63.8 kB
dist/tracing-headers.js 1.76 kB
dist/web-vitals.js 10.4 kB

compressed-size-action

Copy link

@ioannisj ioannisj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, some sorted imports so pre-commit hooks may not running for you?

@lucasheriques lucasheriques merged commit f35df70 into main Jan 21, 2025
32 checks passed
@lucasheriques lucasheriques deleted the fix/expose-getNextSurveyStep-to-use-in-posthog branch January 21, 2025 13:16
@lucasheriques
Copy link
Contributor Author

@ioannisj they always run 🤔 so not sure why did the imports change order

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants