chore: better logging for surveys loaders #1663
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: +6.8 kB (+0.21%) Total Size: 3.27 MB
ℹ️ View Unchanged
|
| @@ -534,7 +538,11 @@ export const sendSurveyEvent = ( | |||
| survey: Survey, | |||
| posthog?: PostHog | |||
| ) => { | |||
| if (!posthog) return | |||
| // TODO: does it need readOnly like dismissedSurveyEvent? | |||
There was a problem hiding this comment.
@lucasheriques since you are working on the preview bits, do we need the readOnly here too? is the preview sending dismissed events?
There was a problem hiding this comment.
no the preview doesn't send and kind of events
There was a problem hiding this comment.
@lucasheriques so should we remove the checks from the other methods?
| @@ -598,7 +598,7 @@ export class PostHog { | |||
| this.sessionRecording?.onRemoteConfig(config) | |||
| this.autocapture?.onRemoteConfig(config) | |||
| this.heatmaps?.onRemoteConfig(config) | |||
| this.surveys?.onRemoteConfig(config) | |||
| this.surveys.onRemoteConfig(config) | |||
There was a problem hiding this comment.
surveys is created on the constructor, never undefined|null
|
@pauldambra just because you're the bundler master and I want to avoid something like https://posthog.slack.com/archives/C07QD3LT8U9/p1737472825108809 |
|
you can always check #1663 (comment) once it's run (and it will update each time you push) to track the impact :) |
marandaneto
added
bump patch
|
Not sure if it's intended but I'm seeing a ton of repeated logs added in this PR. Looks like it's firing once a second |
good point, here it is #1679 |
Changes
It won't fix but It'll help figuring out https://posthoghelp.zendesk.com/agent/tickets/21804
Checklist