Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patch for css parsing performance #1670

Merged
merged 1 commit into from
Jan 22, 2025
Merged

fix: patch for css parsing performance #1670

merged 1 commit into from
Jan 22, 2025

Conversation

pauldambra
Copy link
Member

patches in this PR rrweb-io/rrweb#1615

Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Jan 22, 2025 0:16am

Copy link

Size Change: +2.61 kB (+0.08%)

Total Size: 3.27 MB

Filename Size Change
dist/all-external-dependencies.js 208 kB +373 B (+0.18%)
dist/array.full.js 369 kB +373 B (+0.1%)
dist/array.full.no-external.js 368 kB +373 B (+0.1%)
dist/module.full.js 369 kB +373 B (+0.1%)
dist/module.full.no-external.js 368 kB +373 B (+0.1%)
dist/recorder-v2.js 116 kB +373 B (+0.32%)
dist/recorder.js 116 kB +373 B (+0.32%)
ℹ️ View Unchanged
Filename Size
dist/array.full.es5.js 265 kB
dist/array.js 181 kB
dist/array.no-external.js 180 kB
dist/customizations.full.js 13.8 kB
dist/dead-clicks-autocapture.js 14.4 kB
dist/exception-autocapture.js 9.48 kB
dist/external-scripts-loader.js 2.64 kB
dist/main.js 182 kB
dist/module.js 181 kB
dist/module.no-external.js 180 kB
dist/surveys-preview.js 67.1 kB
dist/surveys.js 63.8 kB
dist/tracing-headers.js 1.76 kB
dist/web-vitals.js 10.4 kB

compressed-size-action

@pauldambra
Copy link
Member Author

this is already in https://github.com/PostHog/posthog-rrweb and doesn't need adding there

Copy link

@veryayskiy veryayskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch it all!

@pauldambra
Copy link
Member Author

tests validated locally
we've had ~6 reports of impact here so force merging in advance of CI going green on this PR

@pauldambra pauldambra merged commit 35b65d4 into main Jan 22, 2025
32 checks passed
@pauldambra pauldambra deleted the fix/patch-css-pr branch January 22, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants