refactor: Remove/deprecate/rename old options #1694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: -1.19 kB (-0.04%) Total Size: 3.28 MB
ℹ️ View Unchanged
|
robbie-c
reviewed
Jan 27, 2025
src/posthog-core.ts
Outdated
| @@ -133,20 +132,20 @@ export const defaultConfig = (): PostHogConfig => ({ | |||
| persistence: 'localStorage+cookie', // up to 1.92.0 this was 'cookie'. It's easy to migrate as 'localStorage+cookie' will migrate data from cookie storage | |||
| persistence_name: '', | |||
| loaded: __NOOP, | |||
| store_google: true, | |||
| save_marketing_params: true, | |||
There was a problem hiding this comment.
Naming:
- I'd probably call these attribution_params if I was starting from scratch. They aren't just for marketing, and product engineers should also care about them, because customers from different channels will have different levels of intent to use/buy your product :)
- custom_campaign_params is calling them campaign_params - so we could also match that naming for consistency
There was a problem hiding this comment.
💯%, let me tweak that
There was a problem hiding this comment.
Well, I tweaked to attribution, but we should instead keep it consistent, let me tweak it again
There was a problem hiding this comment.
Now, really done, great suggestion
rafaeelaudibert
force-pushed
the
deprecate-and-remove-unused-config
branch
from
78b22d9 to
dda063d
Compare
This is extracted from #1681 We're doing some different things here: - `save_marketing_params` over `store_google` because we do much more than just handling Google params with this settings - Deprecate `verbose` in favor of `debug` - Retire `inapp_protocol` and `inapp_link_new_window`, we're not using them anywhere, but we'll keep in the type for backwards-compatibility - Completely remove `__preview_send_client_session_params`, I've checked and it's not being used by anyone in production
rafaeelaudibert
force-pushed
the
deprecate-and-remove-unused-config
branch
from
dda063d to
ece16ed
Compare
robbie-c
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This was extracted from #1681
We're doing some different things here:
save_marketing_paramsoverstore_googlebecause we do much more than just handling Google params with this settingsverbosein favor ofdebuginapp_protocolandinapp_link_new_window, we're not using them anywhere, but we'll keep in the type for backwards-compatibility__preview_send_client_session_params, I've checked and it's not being used by anyone in productionI'm making this a minor bump, and then the remaining changes in #1681 will be only docs, and will be a patch version