Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mobile libraries section to session page #9446

Closed
wants to merge 2 commits into from

Conversation

joethreepwood
Copy link
Contributor

Changes

Now that we've got mobile replays in a better place, i feel like we can emphasize this better on the product page. I put together a quick section for it, but then when I try to add links into the subfeature desc it breaks like this:

Screenshot 2024-09-26 at 14 51 21

I could look at making the subfeature component support links, but when i've tried to do that it's broken. Soooo, parking this here for W&D to consider and maybe help with? 🤞

Checklist

  • Words are spelled using American English
  • Titles are in sentence case
  • Feature names are in sentence case too
  • Use relative URLs for internal links
  • If I moved a page, I added a redirect in vercel.json
  • Remove this template if you're not going to fill it out!

Article checklist

  • I've added (at least) 3-5 internal links to this new article
  • I've added keywords for this page to the rank tracker in Ahrefs
  • I've checked the preview build of the article
  • The date on the article is today's date
  • I've added this to the relevant "Tutorials and guides" docs page (if applicable)

Useful resources

Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog ✅ Ready (Inspect) Visit Preview Oct 1, 2024 8:31am

@marandaneto
Copy link
Member

@smallbrownbike can you redeploy vercel so we can check the preview? thanks.

@marandaneto
Copy link
Member

Screenshot 2024-10-01 at 10 35 11

@joethreepwood something did not work here.

@joethreepwood
Copy link
Contributor Author

joethreepwood commented Oct 1, 2024

@marandaneto Yeah, as I noted in the top comment 🤣

It's because I'm trying to use links (to the docs) in the <subfeature> component, which doesn't support them currently. I wasn't able to fix this quickly, so I think it needs a bit of @corywatilo / @smallbrownbike attention to fix or close.

                            <Subfeature
                                title="Mobile"
                                description={
                                    <>
                                        Replays supported on <a href="/docs/libraries/android">Android</a>,
                                        <a href="/docs/libraries/ios"> iOS</a>,
                                        <a href="/docs/libraries/react-native"> React Native</a>,
                                        <a href="/docs/libraries/flutter"> Flutter</a>, and more.
                                    </>
                                }
                            />

Copy and design is there, just the links that don't work. I imagine W&D will have some better ideas for achieving this though anyway!

@joethreepwood joethreepwood marked this pull request as draft October 1, 2024 08:38
@joethreepwood
Copy link
Contributor Author

This is duplicated in #9778

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants