fix(flags): prevent error when editing flag which lacks payloads (#27994

)
PostHog · Jan 29, 2025 · 581b80c · 581b80c
1 parent 849d3d4
commit 581b80c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/frontend/src/scenes/feature-flags/activityDescriptions.tsx b/frontend/src/scenes/feature-flags/activityDescriptions.tsx
@@ -62,7 +62,7 @@ const featureFlagActionsMapping: Record<
             } else {
                 filtersAfter.payloads &&
                     Object.keys(filtersAfter.payloads).forEach((key: string) => {
-                        const changedPayload = filtersAfter.payloads[key]?.toString() || null
+                        const changedPayload = filtersAfter.payloads?.[key]?.toString() || null
                         changes.push(<SentenceList listParts={[changedPayload]} prefix="changed payload to" />)
                     })
 
@@ -145,7 +145,7 @@ const featureFlagActionsMapping: Record<
         if (isMultivariateFlag) {
             filtersAfter.payloads &&
                 Object.keys(filtersAfter.payloads).forEach((key: string) => {
-                    const changedPayload = filtersAfter.payloads[key]?.toString() || null
+                    const changedPayload = filtersAfter.payloads?.[key]?.toString() || null
                     changes.push(
                         <SentenceList
                             listParts={[

diff --git a/frontend/src/scenes/feature-flags/featureFlagLogic.ts b/frontend/src/scenes/feature-flags/featureFlagLogic.ts
@@ -129,7 +129,7 @@ export function validateFeatureFlagKey(key: string): string | undefined {
         : undefined
 }
 
-function validatePayloadRequired(payload: JsonType, is_remote_configuration: boolean): string | undefined {
+function validatePayloadRequired(is_remote_configuration: boolean, payload?: JsonType): string | undefined {
     if (!is_remote_configuration) {
         return undefined
     }
@@ -322,9 +322,9 @@ export const featureFlagLogic = kea<featureFlagLogicType>([
                             ValidationErrorType
                         >[],
                         payloads: {
-                            true: validatePayloadRequired(filters?.payloads['true'], is_remote_configuration),
-                        } as unknown as DeepPartialMap<Record<string, JsonType>, ValidationErrorType> | undefined,
-                        // Forced cast necessary to prevent Kea's typechecking from raising "Type instantiation
+                            true: validatePayloadRequired(is_remote_configuration, filters?.payloads?.['true']),
+                        } as any,
+                        // Forced any cast necessary to prevent Kea's typechecking from raising "Type instantiation
                         // is excessively deep and possibly infinite" error
                     },
                 }

diff --git a/frontend/src/types.ts b/frontend/src/types.ts
@@ -2956,9 +2956,9 @@ export interface MultivariateFlagOptions {
 
 export interface FeatureFlagFilters {
     groups: FeatureFlagGroupType[]
-    multivariate: MultivariateFlagOptions | null
+    multivariate?: MultivariateFlagOptions | null
     aggregation_group_type_index?: integer | null
-    payloads: Record<string, JsonType>
+    payloads?: Record<string, JsonType>
     super_groups?: FeatureFlagGroupType[]
 }