fix(experiments): Prevent crash when sharedMetrics isn't loaded (#28663)

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
PostHog · Feb 13, 2025 · 7a01626 · 7a01626
1 parent 61d00f0
commit 7a01626
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 0 deletions.
diff --git a/...snapshots__/scenes-app-experiments--experiment-v-2-with-three-metrics--dark.png b/...snapshots__/scenes-app-experiments--experiment-v-2-with-three-metrics--dark.png
diff --git a/...napshots__/scenes-app-experiments--experiment-v-2-with-three-metrics--light.png b/...napshots__/scenes-app-experiments--experiment-v-2-with-three-metrics--light.png
diff --git a/...pshots__/scenes-app-experiments--experiment-v-3-with-experiment-query--dark.png b/...pshots__/scenes-app-experiments--experiment-v-3-with-experiment-query--dark.png
diff --git a/...shots__/scenes-app-experiments--experiment-v-3-with-experiment-query--light.png b/...shots__/scenes-app-experiments--experiment-v-3-with-experiment-query--light.png
diff --git a/frontend/src/scenes/experiments/experimentLogic.tsx b/frontend/src/scenes/experiments/experimentLogic.tsx
@@ -2023,6 +2023,9 @@ export const experimentLogic = kea<experimentLogicType>([
         compatibleSharedMetrics: [
             (s) => [s.sharedMetrics, s.shouldUseExperimentMetrics],
             (sharedMetrics: SharedMetric[], shouldUseExperimentMetrics: boolean): SharedMetric[] => {
+                if (!sharedMetrics) {
+                    return []
+                }
                 if (shouldUseExperimentMetrics) {
                     return sharedMetrics.filter((metric) => metric.query.kind === NodeKind.ExperimentMetric)
                 }