Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(session-replay): Fix all eventsdata query #27339

Merged
merged 1 commit into from
Jan 7, 2025
Merged

fix(session-replay): Fix all eventsdata query #27339

merged 1 commit into from
Jan 7, 2025

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented Jan 7, 2025

Problem

test in prod they sad... not the format clickhouse wanted

Changes

give clickhouse the format it needs/deserves

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@timgl timgl requested review from fuziontech and pauldambra January 7, 2025 22:58
Copy link
Member

@fuziontech fuziontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the way

@timgl timgl merged commit 4825a8b into master Jan 7, 2025
69 checks passed
@timgl timgl deleted the fix-all-events branch January 7, 2025 22:59
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Size Change: 0 B

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.11 MB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants