style: decouple Playlist and player. #27464
Conversation
It makes the layout more responsive + looks better on mobile
|
Size Change: +150 B (+0.01%) Total Size: 1.13 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated14 snapshot changes in total. 0 added, 14 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
…posthog into style/session-replay-ui
📸 UI snapshots have been updated14 snapshot changes in total. 0 added, 14 modified, 0 deleted:
Triggered by this commit. |
|
doesn't quite work if you drag playlist into notebook (which I missed in mine too!) lack of a border is the biggest thing here... but arguably we don't need to be able to hide the filters any more
|
|
i guess the drag handle for the playlist to notebook interaction is in the wrong place now?
|
There was a problem hiding this comment.
we should probably have the section expanded by default in these stories so that we can see the row rendering is working
There was a problem hiding this comment.
i love that this changes brings this content back into view!
There was a problem hiding this comment.
ah.. i see. the split view hasn't applied to playlists here or in notebooks
| @@ -51,7 +50,7 @@ | |||
|
|
|||
| .SessionRecordingPlaylistHeightWrapper { | |||
| // NOTE: Somewhat random way to offset the various headers and tabs above the playlist | |||
| height: calc(100vh - 15rem); | |||
| height: calc(100vh - 10rem); | |||
There was a problem hiding this comment.
dropping into both of our heads that it would be so cool to be able to remove this and just have this as a min-height and we fill the viewport otherwise
(although that can come... doesn't have to be in this PR 😊)
📸 UI snapshots have been updated5 snapshot changes in total. 0 added, 5 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated11 snapshot changes in total. 0 added, 11 modified, 0 deleted:
Triggered by this commit. |
It makes the layout more responsive + looks better on mobile
Problem
Session replay page is not responsive as playlist and player are coupled.
Changes
Decoupled player and the list. Make them responsive.
Web
Before:
After:
Mobile
Before:
After:
