Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bi): bold number should be a table viz for formatting #27885

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Jan 24, 2025

Problem

  • bold number isn't considered a table viz so formatting doesn't work

Changes

  • consider bold number chart as a table viz

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@EDsCODE EDsCODE requested a review from a team January 24, 2025 21:16
@EDsCODE EDsCODE enabled auto-merge (squash) January 24, 2025 21:18
Copy link
Contributor

Size Change: 0 B

Total Size: 1.16 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.16 MB

compressed-size-action

@EDsCODE EDsCODE merged commit ab89d57 into master Jan 24, 2025
100 checks passed
@EDsCODE EDsCODE deleted the bi-bold-number-formatting branch January 24, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants